Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(zh-cn): update images.mdx #8186

Merged
merged 3 commits into from May 7, 2024
Merged

i18n(zh-cn): update images.mdx #8186

merged 3 commits into from May 7, 2024

Conversation

1574242600
Copy link
Contributor

@1574242600 1574242600 commented May 6, 2024 •
edited

Description (required)

This adds an explicit note about no optimization for remote and public/ images using the standard Markdown syntax.

Related issues & labels (optional)

#8177
#7539

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label May 6, 2024
@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented May 6, 2024 •
edited

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
zh-cn guides/images.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@vercel Vercel
Copy link

vercel bot commented May 6, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 7, 2024 6:17am

@1574242600 @liruifengv
i18n(zh-cn): update images.mdx
c54610b 
Co-authored-by: liruifengv <liruifeng1024@gmail.com>
liruifengv
liruifengv approved these changes May 7, 2024
View reviewed changes
Copy link
Sponsor Member

@liruifengv liruifengv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! Welcome to Team Docs! @1574242600

@liruifengv liruifengv added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label May 7, 2024
@liruifengv liruifengv merged commit 4ed6602 into withastro:main May 7, 2024
8 checks passed
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 9, 2024
@1574242600 @liruifengv @wpplumber
i18n(zh-cn): update images.mdx (withastro#8186)
ee86ea2 
* i18n(zh-cn): update images.mdx

* i18n(zh-cn): update images.mdx

Co-authored-by: liruifengv <liruifeng1024@gmail.com>

---------

Co-authored-by: liruifengv <liruifeng1024@gmail.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@1574242600 @liruifengv @wpplumber
i18n(zh-cn): update images.mdx (withastro#8186)
be186c5 
* i18n(zh-cn): update images.mdx

* i18n(zh-cn): update images.mdx

Co-authored-by: liruifengv <liruifeng1024@gmail.com>

---------

Co-authored-by: liruifengv <liruifeng1024@gmail.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@1574242600 @liruifengv @wpplumber
i18n(zh-cn): update images.mdx (withastro#8186)
0ded6a7 
* i18n(zh-cn): update images.mdx

* i18n(zh-cn): update images.mdx

Co-authored-by: liruifengv <liruifeng1024@gmail.com>

---------

Co-authored-by: liruifengv <liruifeng1024@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liruifengv liruifengv liruifengv approved these changes

Assignees
No one assigned
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@1574242600 @astrobot-houston @liruifengv