Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve nodes description in React integrations docs #8038

Merged
merged 4 commits into from May 3, 2024
Merged

Improve nodes description in React integrations docs #8038

merged 4 commits into from May 3, 2024

Conversation

oscarvz
Copy link
Contributor

@oscarvz oscarvz commented Apr 27, 2024 •
edited

Description (required)

Just a fix for a typo I came across when reading the React integrations docs!

@vercel Vercel
Copy link

vercel bot commented Apr 27, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 3, 2024 8:33pm

@oscarvz oscarvz changed the title Fix typo in React integration docs Fix typo in React integrations docs Apr 27, 2024
@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Apr 27, 2024 •
edited

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/integrations-guide/react.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

sarah11918
sarah11918 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting, and coming here to fix, this typo @oscarvz ! We appreciate that you took the time to contribute, and are happy to welcome you to Team Docs! 🥳

@sarah11918 sarah11918 added typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Apr 30, 2024
@yanthomasdev yanthomasdev added help - confirm behaviour Walk through the example/issue and confirm this is a general behaviour, or a correct update to make. and removed Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Apr 30, 2024
@yanthomasdev
Copy link
Member

yanthomasdev commented Apr 30, 2024 •
edited

Thanks @oscarvz, I'll give this some time for someone who knows the internals of the React integration since the intention might've been to really talk about vnodes, i.e. Virtual DOM Nodes, so despite it sounding like a typo, it might not really be one.

@oscarvz @yanthomasdev
Update src/content/docs/en/guides/integrations-guide/react.mdx
348b2a1 
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
@oscarvz oscarvz changed the title Fix typo in React integrations docs Improve nodes description in React integrations docs May 2, 2024
@sarah11918
Copy link
Member

Looking great now @oscarvz ! Thanks for sticking with us while we got everything straightened out, and again, welcome to Team Docs! 🥳

@sarah11918 sarah11918 merged commit b7d1656 into withastro:main May 3, 2024
8 checks passed
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 4, 2024
@oscarvz @yanthomasdev
@sarah11918 @wpplumber
Improve nodes description in React integrations docs (withastro#8038)
ca51de3 
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@liruifengv liruifengv mentioned this pull request May 7, 2024
Merged
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 9, 2024
@oscarvz @yanthomasdev
@sarah11918 @wpplumber
Improve nodes description in React integrations docs (withastro#8038)
35e10f2 
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanthomasdev yanthomasdev yanthomasdev left review comments

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
help - confirm behaviour Walk through the example/issue and confirm this is a general behaviour, or a correct update to make. typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oscarvz @astrobot-houston @yanthomasdev @sarah11918