Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about --viteMode flag #8016

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

acupofspirt
Copy link

Description (required)

These doc changes describe a new flag for the build and dev commands and add additional information about .env files loading.

Related issues & labels (optional)

  • Suggested label: merge-on-release

For Astro version: 4.8. See astro PR #10871.

Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 1, 2024 10:25am

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Apr 25, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/environment-variables.mdx Source changed, localizations will be marked as outdated.
en reference/cli-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels Apr 30, 2024
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @acupofspirt , this is looking great! I'm sure people will love being able to do this now. 🙌

This was a really nice, well-crafted docs contribution! Just a few suggestions for making it match some of the other entries, and adding our special component for indicating in which version a feature was added. But this will be good to go very easily, I think!

src/content/docs/en/guides/environment-variables.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/environment-variables.mdx Outdated Show resolved Hide resolved
src/content/docs/en/reference/cli-reference.mdx Outdated Show resolved Hide resolved
src/content/docs/en/reference/cli-reference.mdx Outdated Show resolved Hide resolved
@sarah11918 sarah11918 added this to the 4.8 milestone Apr 30, 2024
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants