Fix double/triple click selection issues on headings #8015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
HiDeoo
added
bug
TheOtterlord
approved these changes
Apr 26, 2024
sarah11918
added
the
site improvement
delucis
approved these changes
May 1, 2024
Same, and even after talking with people having a better experience with this than me, the specificity of the selector seems like a wise choice for the time being. |
wpplumber
pushed a commit
to wpplumber/astro-docs
that referenced
this pull request
May 4, 2024
Co-authored-by: Chris Swithinbank <357379+delucis@users.noreply.github.com> Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com> Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
wpplumber
pushed a commit
to wpplumber/astro-docs
that referenced
this pull request
May 9, 2024
Co-authored-by: Chris Swithinbank <357379+delucis@users.noreply.github.com> Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com> Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
This PR fixes some text selection issues when double or triple clicking headings.
A short summary of the issue would be that double/triple click selection on headings could include some extra content when copying the selection. Refer to #8001 for a detailed list of all the issues by browser as the behavior is different in each one and I don't think it is worth duplicating the information here.
The changes fixes all the issues at the same time. I tried various approaches before settling on this one:
A basic space does not fix the issue.
A zero-width space would fix the issue in Chrome and Firefox, but not in Safari. It also has the downside of adding a character, non-visible (and non-conventional) to the text which browsers may or may not include when copying the selected heading.
On top of that, some editors or note-taking apps may highlight such a character if the browser used includes it in the copied text.
For example, here is how it looks in my VS Code when copying the heading with a zero-width space (notice the yellow rectangle at the end of the heading):
The CSS approach used in this PR.
Accessiblity-wise, I couldn't think of any downside of using this approach in this specific case on this specific class (nor could I find any mention of this in my researches) and testing with VoiceOver and NVDA didn't show any change in behavior whatsoever.
For reference, here is a preview of the VoiceOver behavior before and after the change:
Related issues & labels (optional)