Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce __session name for cookie #8014

Merged
merged 3 commits into from May 1, 2024
Merged

Enforce __session name for cookie #8014

merged 3 commits into from May 1, 2024

Conversation

leoxs22
Copy link
Contributor

@leoxs22 leoxs22 commented Apr 25, 2024

Description (required)

Docs snippets are saving a cookie called session

Firebase will remove all cookies except for __session https://firebase.google.com/docs/hosting/manage-cache#using_cookies

Using the current code in the docs will result in a 500 error. Adding a log in a middleware will show that no cookies are being received in the firebase function.

@vercel Vercel
Copy link

vercel bot commented Apr 25, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 1, 2024 3:09pm

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Apr 25, 2024 •
edited

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/backend/google-firebase.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Fryuni
Fryuni requested changes Apr 26, 2024
View reviewed changes
Copy link
Member

@Fryuni Fryuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @leoxs22, thanks for the PR, and welcome to the team 🎉 🎉 🎉

The code seems to be working fine with the fix. I sent a suggestion to the text because it implies more than it should (at least to me, maybe I'm being a bit paranoid). Besides that LGTM

src/content/docs/en/guides/backend/google-firebase.mdx Outdated Show resolved Hide resolved
@leoxs22 @Fryuni
Updated explanation of the issue according to suggestion
1ba1475 
Co-authored-by: Luiz Ferraz <luiz@lferraz.com>
@leoxs22
Copy link
Contributor Author

leoxs22 commented Apr 26, 2024

Thanks! I agree, it looks better that way 😄

@leoxs22 leoxs22 requested a review from Fryuni April 26, 2024 16:47
Fryuni
Fryuni approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@Fryuni Fryuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Fryuni Fryuni added improve documentation Enhance existing documentation (e.g. add an example, improve description) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Apr 27, 2024
@sarah11918 sarah11918 merged commit 59847db into withastro:main May 1, 2024
8 checks passed
@jsparkdev jsparkdev mentioned this pull request May 2, 2024
Merged
thomasbnt added a commit to thomasbnt/docs that referenced this pull request May 2, 2024
@thomasbnt
i18n(fr): Update guides/backend/google-firebase.mdx from withastro#…
287a437 
…8014 (__session)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@thomasbnt thomasbnt mentioned this pull request May 2, 2024
Merged
@leoxs22 leoxs22 deleted the patch-1 branch May 2, 2024 14:05
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 4, 2024
@leoxs22 @Fryuni
@sarah11918 @wpplumber
Enforce __session name for cookie (withastro#8014)
46a5d41 
Co-authored-by: Luiz Ferraz <luiz@lferraz.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@huyikai huyikai mentioned this pull request May 6, 2024
Merged
yanthomasdev added a commit that referenced this pull request May 7, 2024
@thomasbnt @Fryuni
@dreyfus92 @yanthomasdev
i18n(fr): Update guides/backend/google-firebase.mdx from #8014 (__s…
a4cd391 
…ession) (#8153)

* i18n(fr): Update `guides/backend/google-firebase.mdx` from #8014 (__session)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* Update src/content/docs/fr/guides/backend/google-firebase.mdx

Co-authored-by: Luiz Ferraz <luiz@lferraz.com>

---------

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Luiz Ferraz <luiz@lferraz.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 9, 2024
@leoxs22 @Fryuni
@sarah11918 @wpplumber
Enforce __session name for cookie (withastro#8014)
8eeb45f 
Co-authored-by: Luiz Ferraz <luiz@lferraz.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 9, 2024
@thomasbnt @Fryuni
@dreyfus92 @yanthomasdev @wpplumber
i18n(fr): Update guides/backend/google-firebase.mdx from withastro#…
ed6c35a 
…8014 (__session) (withastro#8153)

* i18n(fr): Update `guides/backend/google-firebase.mdx` from withastro#8014 (__session)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* Update src/content/docs/fr/guides/backend/google-firebase.mdx

Co-authored-by: Luiz Ferraz <luiz@lferraz.com>

---------

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Luiz Ferraz <luiz@lferraz.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryuni Fryuni Fryuni approved these changes

Assignees
No one assigned
Labels
improve documentation Enhance existing documentation (e.g. add an example, improve description) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@leoxs22 @astrobot-houston @Fryuni @sarah11918