Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(es): Translate internationalization.mdx #7985

Merged
merged 20 commits into from Apr 30, 2024
Merged

Conversation

ansango
Copy link
Contributor

@ansango ansango commented Apr 23, 2024

Description (required)

Translate internationalization.mdx into -es

Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Apr 30, 2024 5:14pm

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Apr 23, 2024
@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Apr 23, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
es guides/internationalization.mdx Localization added, will be marked as complete.
es reference/api-reference.mdx Localization changed, will be marked as complete.
es reference/errors/incorrect-strategy-for-i18n.mdx Localization changed, will be marked as complete.
es reference/errors/missing-index-for-internationalization.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Contributor

@Waxer59 Waxer59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buena PR 🤠, te dejo unas sugerencias!

src/content/docs/es/guides/internationalization.mdx Outdated Show resolved Hide resolved
src/content/docs/es/guides/internationalization.mdx Outdated Show resolved Hide resolved
src/content/docs/es/guides/internationalization.mdx Outdated Show resolved Hide resolved
src/content/docs/es/guides/internationalization.mdx Outdated Show resolved Hide resolved
src/content/docs/es/guides/internationalization.mdx Outdated Show resolved Hide resolved
src/content/docs/es/guides/internationalization.mdx Outdated Show resolved Hide resolved
src/content/docs/es/guides/internationalization.mdx Outdated Show resolved Hide resolved
src/content/docs/es/guides/internationalization.mdx Outdated Show resolved Hide resolved
src/content/docs/es/guides/internationalization.mdx Outdated Show resolved Hide resolved
ansango and others added 7 commits April 25, 2024 00:36
Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>
Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>
Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>
Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>
Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>
Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>
Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>
@ansango
Copy link
Contributor Author

ansango commented Apr 24, 2024

@Waxer59 muchas gracias por la revision 😸

ansango and others added 2 commits April 25, 2024 00:37
Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>
Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Buen trabajo @ansango 😁, te dejo una pequeña sugerencia.

src/content/docs/es/guides/internationalization.mdx Outdated Show resolved Hide resolved
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
@ansango
Copy link
Contributor Author

ansango commented Apr 26, 2024

Buen trabajo @ansango 😁, te dejo una pequeña sugerencia.

Mil gracias!!!, 8 ojos ven más que dos! 😅

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muchas gracias @ansango y bienvenido a astro-docs 🫡

@dreyfus92 dreyfus92 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Apr 26, 2024
@dreyfus92
Copy link
Member

dreyfus92 commented Apr 26, 2024

@ansango, parece que todavía queda pendiente resolver los problemas que tienen los links. Si necesitas ayuda me puedes pinguear aquí o en discord.

@dreyfus92 dreyfus92 removed the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Apr 26, 2024
@ansango
Copy link
Contributor Author

ansango commented Apr 27, 2024

@dreyfus92 Creo que ya deberia de funcionar todo correctamente, links arreglados y probados 😄

@yanthomasdev
Copy link
Member

Looks like we're missing a few headings in the Spanish translation of API Reference (e.g. Astro.preferredLocale), that's why the broken links. Could any of you take a look and make sure to add these to the api-reference.mdx translation?

@ansango
Copy link
Contributor Author

ansango commented Apr 30, 2024

Looks like we're missing a few headings in the Spanish translation of API Reference (e.g. Astro.preferredLocale), that's why the broken links. Could any of you take a look and make sure to add these to the api-reference.mdx translation?

Thank you for the review @yanthomasdev, I fixed and added new translations in api-reference.mdx. I hope build will be ok! 😄

@dreyfus92
Copy link
Member

There are still 4 broken links, we're almost there to ship this @ansango 😁

@ansango
Copy link
Contributor Author

ansango commented Apr 30, 2024

There are still 4 broken links, we're almost there to ship this @ansango 😁

Sure! I reviewed the previous gh action, and I built on my desktop, so I hope that we'll be ready now 😄

@dreyfus92 dreyfus92 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Apr 30, 2024
@dreyfus92
Copy link
Member

Muchas gracias @ansango, ya quedó 🥳

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work everyone, and welcome to Team Docs @ansango!

@yanthomasdev yanthomasdev merged commit 7597fdf into withastro:main Apr 30, 2024
8 checks passed
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 4, 2024
* feat: adding internationalization -es

* Update internationalization.mdx

* Update src/content/docs/es/guides/internationalization.mdx

Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>

* Update src/content/docs/es/guides/internationalization.mdx

Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>

* Update src/content/docs/es/guides/internationalization.mdx

Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>

* Update src/content/docs/es/guides/internationalization.mdx

Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>

* Update src/content/docs/es/guides/internationalization.mdx

Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>

* Update src/content/docs/es/guides/internationalization.mdx

Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>

* Update src/content/docs/es/guides/internationalization.mdx

Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>

* Update src/content/docs/es/guides/internationalization.mdx

Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>

* Update src/content/docs/es/guides/internationalization.mdx

Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>

* Update src/content/docs/es/guides/internationalization.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* fix: reviewing all links and fixed all missed and broken links

* fix: updating broken links from api-reference including new translations

* fix: broken links at error routes

---------

Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 9, 2024
* feat: adding internationalization -es

* Update internationalization.mdx

* Update src/content/docs/es/guides/internationalization.mdx

Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>

* Update src/content/docs/es/guides/internationalization.mdx

Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>

* Update src/content/docs/es/guides/internationalization.mdx

Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>

* Update src/content/docs/es/guides/internationalization.mdx

Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>

* Update src/content/docs/es/guides/internationalization.mdx

Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>

* Update src/content/docs/es/guides/internationalization.mdx

Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>

* Update src/content/docs/es/guides/internationalization.mdx

Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>

* Update src/content/docs/es/guides/internationalization.mdx

Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>

* Update src/content/docs/es/guides/internationalization.mdx

Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>

* Update src/content/docs/es/guides/internationalization.mdx

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>

* fix: reviewing all links and fixed all missed and broken links

* fix: updating broken links from api-reference including new translations

* fix: broken links at error routes

---------

Co-authored-by: Waxer59 <78129249+Waxer59@users.noreply.github.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants