Generate OG images as WebP #7940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
delucis
added
the
site improvement
delucis
commented
Apr 18, 2024
There was a problem hiding this comment.
Seeing some errors in the build now it redeployed with content collection caching enabled, for example on the homepage:
From a quick look through, it seems to all be missing CSS for components in MDX. Their JS is loading though — only styles are missing.
Something for @matthewp to maybe look at now we have this test case.
|
Update branch to bring in #7952 and now the deployment preview looks OK again! |
|
Did some checks in online preview generators and all looks good I think!
|
|
Oooh, nice work — thank you @sarah11918! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
astro-og-canvasto the latest release (required for WebP output).webpinstead of.pngN.B. When first building on Vercel the build was still over the build cache limit because I guess it includes all those old OG images which aren’t ever cleared out by
astro-og-canvas. I reran without the cache and then it successfully cached the result with a size of only c. 250 MB. So we just need to vacate the cache once we merge this tomainI suspect and we should be good to go.But the big news is…
With a warm cache and content collection caching working as added in #7535, I got a build completing in 2m46s — https://vercel.com/astrodotbuild/docs/CTPGZ2Z2juaEqgj4xbfqqBMcxi3v