Add title and adjust highlight in configured redirects code samples #3992
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
sarah11918
added
the
improve documentation
There was a problem hiding this comment.
Thanks so much for jumping on this @AishaBlake! I love me some consistent titles, and oh no, how did we never catch the previous wonky highlighting? 😅
Just quick suggestion below to see what you think, and so thrilled to be welcoming you to Team Docs! 🥳
| @@ -251,7 +251,7 @@ These redirects follow the same rules as file-based routes. Dynamic routes are a | |||
|
|
|||
| Using SSR or a static adapter, you can also provide an object as the value, allowing you to specify the `status` code in addition to the new `destination`: | |||
|
|
|||
| ```js | |||
| ```js title="astro.config.mjs" {5-8} | |||
There was a problem hiding this comment.
Totally agree with not also highlighting redirects here, since we're focusing on the object that you can provide! 🙌
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
|
Your suggestion makes sense to me, @sarah11918! Thanks for the warm welcome. Contributing here reminds me of the parts that I actually enjoyed of a certain previous job. 😅 |
There was a problem hiding this comment.
Looking great to me! I'm approving to get this in our merge queue, since it's a constant "update branch" battle around here while Yan is merging translation PRs. But this will go live just as soon as can!
Thanks again for taking the time to contribute while I know you're so busy with other, non-tech endeavours. Does this mean... maybe we see an Astro Opal Grove Games website in the near future??? 👀 😄
|
Actually, yes! I migrated my personal site as a test and now I'm working on moving Opal Grove's over. Starting with the one Astro Shopify theme but I've got a bunch of things I want to add 🤩 I'll share more on Twitter but excited about this first little PR! |
…ithastro#3992) Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
What kind of changes does this PR include?
Description
Before:
After:
