Improve MDX optimize with sibling nodes #10887
Conversation
馃 Changeset detectedLatest commit: 8c3a6fc The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
| const objectPropertyNodes = child.data.estree.body[0]?.declarations?.[0]?.init?.properties; | ||
| const objectPropertyNodes = | ||
| child.data.estree?.body[0]?.declaration?.declarations?.[0]?.init?.properties; |
There was a problem hiding this comment.
The previous access was incorrect and never actually worked 馃槄 I should look into properly typing this in the future.
|
Thanks, I'll add a test 馃憤 There's currently the |
|
I added a unit test. It now reveals that it generates some cursed JSX code that has attribute values with quotes extending multiple lines, but it still seems to parse properly and we don't have to manually escape the new lines, so leaving it like so for now. |
* fix(mdx): convert remark-images-to-component plugin to a rehype plugin (#10697) * Remove fs read for MDX transform (#10866) * Tag MDX component for faster checks when rendering (#10864) * Use unified plugin only for MDX transform (#10869) * Only traverse children and handle mdxJsxTextElement when optimizing (#10885) * Rename to `optimize.ignoreComponentNames` in MDX (#10884) * Allow remark/rehype plugins added after mdx to work (#10877) * Improve MDX optimize with sibling nodes (#10887) * Improve types in rehype-optimize-static.ts * Rename `ignoreComponentNames` to `ignoreElementNames` I think this better reflects what it's actually doing * Simplify plain MDX nodes in optimize option (#10934) * Format code * Minimize diff changes * Update .changeset/slimy-cobras-end.md Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> --------- Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com> Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Changes
There was a flaw with how
rehype-optimize-static.tsworked before. Take this page for example https://docs.astro.build/en/concepts/why-astro/, which is a static page with no components.Before, the rehype plugin will only transform to something like this:
With this PR, it can go one step further and transform as:
Which is only a single line and a single string, which simplifies the AST nodes and runtime rendering.
Performance:
After multiple runs, the timings fluctuate a bit so it's hard to tell of the improvements. But averaging it, the total build time drop from 126s to 124s. I thought it would be more, but I'll take the small win 馃ゲ
Testing
The
mdx-optimizeplayground that should still pass. And I tested in the Astro docs repo.Docs
Added a changeset and updated the internal README explaining the new code.