feat(env): server/public variables #10881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com> Co-authored-by: Emanuele Stoppa <my.burning@gmail.com>
|
github-actions
bot
added
pkg: astro
ematipico
reviewed
Apr 26, 2024
bluwy
approved these changes
Apr 29, 2024
Comment on lines
+1171
to
+1179
| /** | ||
| * @docs | ||
| * @description | ||
| * Module is only available server-side | ||
| */ | ||
| export const EnvServerOnlyModule = { | ||
| name: 'EnvServerOnlyModule', | ||
| title: 'Module is only available server-side', | ||
| message: (name: string) => `The "${name}" module is only available server-side.`, |
There was a problem hiding this comment.
Some thoughts for myself: I know we have a few virtual modules that currently only meant to work in the server-side only. Maybe we can consider making this more generic later. We don't have to change this now.
matthewp
approved these changes
Apr 30, 2024
ematipico
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Docs
N/A