Make status code check more strict for sitemap plugin #10779
+50
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a39f0a8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
adrianlyjak
force-pushed
the
404-fix
branch
2 times, most recently
from
1f67782
to
c116eb3
Compare
|
Can you rebase against |
|
@matthewp 👌 rebased and all checks pass |
bholmesdev
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
This fix looks good to me! Confirmed that 404 and 500 should only be detected from src/pages in our docs, and should include localized version as well per the i18n middleware. We Adri-can merge I think @adrianlyjak
bholmesdev
reviewed
Apr 24, 2024
Co-authored-by: Ben Holmes <hey@bholmes.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential fix for #10778
Changes
[locale]/[error-code]and[error-code]style pages are excludedTesting
Updated existing test fixture and added test for this scenario
Docs
The current exclusion logic isn't documented, so it seems unnecessary to add further documentation about this edge case. IMO, this seems like a bug