Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for bug reproduction #10738

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

test for bug reproduction #10738

wants to merge 2 commits into from

Conversation

alexanderniebuhr
Copy link
Member

@alexanderniebuhr alexanderniebuhr commented Apr 10, 2024

@matthewp this adds a test to reproduce the issue:

  1. pnpm i && pnpm run build
  2. node --test "packages/astro/test/ssr-prerender-chunk.test.js"
  3. Open packages/astro/test/fixtures/ssr-prerender-chunks/dist/_worker.js/renderers.mjs
  4. Follow the imports from that file import { r as reactExports, R as React } from './chunks/prerender_dvgq6Avf.mjs';
  5. Open packages/astro/test/fixtures/ssr-prerender-chunks/dist/_worker.js/chunks/prerender_dvgq6Avf.mjs
  6. See that the chunking tries to import from a file with noop content

It is not possible to test this with the exisiting testAdapter, since that relies on fs and also doesn't use a real serverEntrypoint but a Vite virtual import. I expect this is an issue with manualChunks settings of Astro core, but it might could be also an issue with some settings for the serverless-test-adapter. Still I'm very lost and would love to get help & or a fix!

(Maybe @bluwy has also an idea 🤔)

As my debugging goes the following issues are downstream issues caused by this:

@alexanderniebuhr alexanderniebuhr marked this pull request as draft April 10, 2024 07:43
Copy link

changeset-bot bot commented Apr 10, 2024

⚠️ No Changeset found

Latest commit: f95ace9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant