Adding support for toml data entry #10484
Open
+120
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c28ae9e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
|
What is this for? Sorry if it's obvious/dumb question. |
|
plus support, I use both rust and astro on the same project, this would help out a ton. |
ematipico
requested changes
May 8, 2024
There was a problem hiding this comment.
Some things you need to address:
- explain the PR to us reviewers, and why you added it
- change the changeset, and make it a
minor - expand the changeset, and explain the new feature with an example. We want to explain things to users
- open a PR to update the documentation
- add an example in
examples/folder
|
yes, let me do it tonight |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
.tomlextensionTesting
I checked the repository, yet unable to see existing tests for JSON, YAML and TOML data entry points,
If so, there is need for adding tests for these data entry points let me know, I am happy to contribute
Docs
Adding Support for .toml file in src/content folder with existing data formats json, yaml