LuaLS Annotations + Documentation #443
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wire team will tell you is a waste of time. I had only one patch like this ever merged :D but good effort nonetheless! |
thegrb93
reviewed
Nov 7, 2023
| @@ -1272,7 +1291,7 @@ local function AdvDupe2_Spawn() | |||
| end | |||
|
|
|||
| AdvDupe2.SpawningEntity = true | |||
| local Ent = CreateEntityFromTable(v, Queue.Player) | |||
There was a problem hiding this comment.
Why remove this local? Please make sure there's no code changes are in this PR if you're going to add a ton of function comments.
There was a problem hiding this comment.
I have no clue how this happened.
These are useful additions. Your PRs had issues because you always wanted to include a bunch of cleanup or style changes along with your bugfixes. |
|
@Denneisk you never marked this ready for review. Is it? |
|
I forgot about this lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotates everything with LuaLS annotations, providing critical documentation that would otherwise require carefully tracing the execution flow of AdvDupe2.
I hope that future contributors will be able to benefit from my progressive understanding of AdvDupe2.
Let me know if this is a waste of time before I keep going, and if any changes need to be made.