Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WT-12991 Don't allow prefetch to be enabled for in-memory databases #10598

Merged
merged 3 commits into from
May 22, 2024
Merged

WT-12991 Don't allow prefetch to be enabled for in-memory databases #10598

merged 3 commits into from
May 22, 2024

Conversation

etienneptl
Copy link
Contributor

No description provided.

@etienneptl etienneptl self-assigned this May 16, 2024
@evergreen-ci-prod Evergreen CI Prod
Copy link

Test coverage is too low, this change probably shouldn't be merged as-is.

Metric (for added/changed code) Coverage
Line coverage 50% (1/2)
Branch coverage 75% (3/4)

⚠️ This PR touches methods that have an extremely high complexity score!

  • In src/conn/conn_api.c the complexity of wiredtiger_open has increased by 2 to 54.

mm-ng
mm-ng approved these changes May 19, 2024
View reviewed changes
Copy link
Contributor

@mm-ng mm-ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kommiharibabu
kommiharibabu approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@kommiharibabu kommiharibabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

luke-pearson
luke-pearson approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@luke-pearson luke-pearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@etienneptl etienneptl added this pull request to the merge queue May 22, 2024
Merged via the queue into develop with commit 588ef87 May 22, 2024
7 checks passed
@etienneptl etienneptl deleted the wt-12991-prefetch-inmem branch May 22, 2024 00:34
@etienneptl etienneptl mentioned this pull request May 22, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request May 23, 2024
@etienneptl
Revert "WT-12991 Don't allow prefetch to be enabled for in-memory dat…
73280c1 
…abases" (#10631)

Reverts #10598
@etienneptl etienneptl restored the wt-12991-prefetch-inmem branch May 24, 2024 05:48
@evergreen-ci-prod evergreen-ci-prod bot mentioned this pull request May 24, 2024
Merged
@etienneptl etienneptl deleted the wt-12991-prefetch-inmem branch May 27, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luke-pearson luke-pearson luke-pearson approved these changes

@kommiharibabu kommiharibabu kommiharibabu approved these changes

@mm-ng mm-ng mm-ng approved these changes

Assignees

@etienneptl etienneptl

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@etienneptl @luke-pearson @kommiharibabu @mm-ng