-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WT-12986 External subsystem functions wt -> wti. #10589
Conversation
Test coverage is ok, please try and improve it if that's feasible.
|
As you can imagine this touches most of the files. It all should be a renaming. There were a few static functions that were prefixed with Do we want to move forward with this? (I put this into the ticket also, so discussion should be recorded there.) |
We agreed to move forward with this so please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (I really just skimmed, I didn't check for correctness, but I feel like a compiler does that job better than me in this case) - I think this is a big improvement, thanks for taking the time!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although I admit that I also was mostly just skimming. I added a few (mostly) minor comments. Thank you for the very nice cleanup - this is a good improvement!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Sue. LGTM!
Two suggestions for additional support to go with this change.
- Could you also add an item to the coding guidelines (currently living in the top-level
CONTRIBUTING.rst
file) to explain__wti
usage. - Do you think it is feasible to have an
s_all
script that checks for cross module calls to__wti
methods? If so, would you create a ticket for that?
Yes, this would be great! Definitely feasible, but maybe indeed better in a separate ticket (I'd be happy to do this, if you'd like to pass it off to someone else). |
Add naming text to CONTRIBUTING.rst
@pmacko86 and @keitharnoldsmith I created WT-13031 for the dist script. I also fixed |
No description provided.