Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WT-12986 External subsystem functions wt -> wti. #10589

Merged
merged 29 commits into from
May 21, 2024
Merged

Conversation

sueloverso
Copy link
Member

No description provided.

@sueloverso sueloverso changed the title Wt 12986 api WT-12986 External subsystem functions wt -> wti. May 13, 2024
@sueloverso sueloverso marked this pull request as draft May 13, 2024 20:19
Copy link

evergreen-ci-prod bot commented May 13, 2024

Test coverage is ok, please try and improve it if that's feasible.

Metric (for added/changed code) Coverage
Line coverage 85% (1009/1191)
Branch coverage 51% (454/886)

⚠️ This PR touches methods that have an extremely high complexity score!

  • In src/btree/row_modify.c the complexity of __wt_row_modify has increased by 1 to 47.
  • In src/conn/conn_reconfig.c the complexity of __wti_conn_compat_config has increased by 32 to 32.
  • In src/history/hs_rec.c the complexity of __wt_hs_insert_updates has increased by 3 to 70.
  • In src/lsm/lsm_merge.c the complexity of __wti_lsm_merge has increased by 38 to 38.
  • In src/reconcile/rec_col.c the complexity of __wti_rec_col_fix has increased by 64 to 64.
  • In src/reconcile/rec_col.c the complexity of __wti_rec_col_var has increased by 76 to 76.
  • In src/reconcile/rec_row.c the complexity of __wti_rec_row_leaf has increased by 43 to 43.
  • In src/reconcile/rec_visibility.c the complexity of __wti_rec_upd_select has increased by 46 to 46.
  • In src/rollback_to_stable/rts_btree_walk.c the complexity of __wti_rts_btree_walk_btree_apply has increased by 34 to 34.

@sueloverso sueloverso marked this pull request as ready for review May 20, 2024 13:22
@sueloverso
Copy link
Member Author

As you can imagine this touches most of the files. It all should be a renaming. There were a few static functions that were prefixed with wt that I fixed. Some static functions I moved before their usage in their file. But most of this should be straightforward.

Do we want to move forward with this? (I put this into the ticket also, so discussion should be recorded there.)

@sueloverso
Copy link
Member Author

We agreed to move forward with this so please review.

Copy link
Member

@agorrod agorrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (I really just skimmed, I didn't check for correctness, but I feel like a compiler does that job better than me in this case) - I think this is a big improvement, thanks for taking the time!

Copy link
Contributor

@pmacko86 pmacko86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I admit that I also was mostly just skimming. I added a few (mostly) minor comments. Thank you for the very nice cleanup - this is a good improvement!

src/os_posix/os_fs.c Outdated Show resolved Hide resolved
src/reconcile/rec_track.c Show resolved Hide resolved
test/unittest/tests/test_reconciliation_tracking.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@keitharnoldsmith keitharnoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Sue. LGTM!

Two suggestions for additional support to go with this change.

  • Could you also add an item to the coding guidelines (currently living in the top-level CONTRIBUTING.rst file) to explain __wti usage.
  • Do you think it is feasible to have an s_all script that checks for cross module calls to __wti methods? If so, would you create a ticket for that?

@pmacko86
Copy link
Contributor

  • Do you think it is feasible to have an s_all script that checks for cross module calls to __wti methods? If so, would you create a ticket for that?

Yes, this would be great! Definitely feasible, but maybe indeed better in a separate ticket (I'd be happy to do this, if you'd like to pass it off to someone else).

@sueloverso
Copy link
Member Author

@pmacko86 and @keitharnoldsmith I created WT-13031 for the dist script. I also fixed CONTRIBUTING.rst.

@sueloverso sueloverso added this pull request to the merge queue May 21, 2024
Merged via the queue into develop with commit 8fcbb2e May 21, 2024
7 checks passed
@sueloverso sueloverso deleted the wt-12986-api branch May 21, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants