Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WT-12068 Use release build and enable tcmalloc for perf test #10579

Merged
merged 1 commit into from
May 21, 2024
Merged

WT-12068 Use release build and enable tcmalloc for perf test #10579

merged 1 commit into from
May 21, 2024

Conversation

quchenhao
Copy link
Contributor

No description provided.

@quchenhao quchenhao requested a review from lukech May 10, 2024 01:30
@lukech
Copy link
Contributor

lukech commented May 10, 2024

@quchenhao do we have a perf patch build (or two) to understand how much variance this change could have introduced?

@lukech lukech requested review from ajmorton and ershov May 10, 2024 04:11
@quchenhao
Copy link
Contributor Author

quchenhao commented May 10, 2024 •
edited

@quchenhao do we have a perf patch build (or two) to understand how much variance this change could have introduced?

https://spruce.mongodb.com/version/663d6f97e891090007228944/tasks?page=0&sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC&statuses=running-umbrella,started,dispatched&variant=%5Eubuntu2004-perf-tests%24

I've run a patch. There appears to be some small regressions.

lukech
lukech approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@lukech lukech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quchenhao
Copy link
Contributor Author

@ershov Can you look at this?

@quchenhao quchenhao added this pull request to the merge queue May 21, 2024
Merged via the queue into develop with commit f6c0d70 May 21, 2024
7 checks passed
@quchenhao quchenhao deleted the wt-12068-improve-perf-test branch May 21, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ershov ershov ershov approved these changes

@lukech lukech lukech approved these changes

@ajmorton ajmorton Awaiting requested review from ajmorton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@quchenhao @lukech @ershov