WT-12901:txn timestamp's log improve #10526
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @y123456yz, thank you for your submission! |
y123456yz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The set_timestamp time parameter is hexadecimal:
testutil_check(conn->set_timestamp(conn, "oldest_timestamp=10, stable_timestamp=10"));
the log info as following(be hexadecimal):
[1714312199:96018][105276:0x7fa976f4f800], WT_CONNECTION.__conn_set_timestamp: [WT_VERB_TIMESTAMP][DEBUG_1]: Timestamp (0, 16): Updated global oldest timestamp
[1714312199:96023][105276:0x7fa976f4f800], WT_CONNECTION.__conn_set_timestamp: [WT_VERB_TIMESTAMP][DEBUG_1]: Timestamp (0, 16): Updated global stable timestamp
[1714312199:96034][105276:0x7fa976f4f800], WT_CONNECTION.__conn_set_timestamp: [WT_VERB_TIMESTAMP][DEBUG_1]: Timestamp (0, 16): Updated pinned timestamp
[1714312199:96040][105276:0x7fa976f4f800], WT_CONNECTION.__conn_set_timestamp: [WT_VERB_API][DEBUG_1]: CALL: WT_CONNECTION:__conn_set_timestamp
The set_timestamp time parameter is hexadecimal, so it is recommended that timestamp output also be hexadecimal, so that it is consistent.
The first time I saw the log, I thought the log output was wrong because I mistakenly thought the set_timestamp parameter was decimal.