WT-12554 Treat git clone failures as setup failures in Evergreen #10428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the evergreen builds we have a number of places where `git clone` is invoked in the middle of a complex build step. This can result in git problems being tracked as "test failures" This PR factors out those commands into their own steps where possible and marks them as setup steps to allow us to better track failure reasons in our build stats.
jbergler
commented
Mar 27, 2024
lukech
reviewed
Mar 27, 2024
lukech
reviewed
Mar 27, 2024
lukech
reviewed
Apr 4, 2024
| @@ -3065,9 +3074,8 @@ tasks: | |||
| ####################################################### | |||
| # Obtain the complexity metrics for the 'previous' code | |||
| ####################################################### | |||
| git clone https://github.com/wiredtiger/wiredtiger.git wiredtiger_previous | |||
| git worktree add --detach wiredtiger_previous "${github_commit}" | |||
There was a problem hiding this comment.
I learnt the git worktree command today :)
tod-johnson-mongodb
pushed a commit
that referenced
this pull request
Apr 19, 2024
) In the evergreen builds we have a number of places where `git clone` is invoked in the middle of a complex build step. This can result in git problems being tracked as "test failures" This PR either: - factors out those commands into their own steps where possible and marks them as setup steps to allow us to better track failure reasons in our build stats; or - replaces them with an equivalent that doesn't require network access (eg `git worktree add`)
tod-johnson-mongodb
pushed a commit
that referenced
this pull request
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the evergreen builds we have a number of places where
git cloneis invoked in the middle of a complex build step. This can result in git problems being tracked as "test failures"This PR either:
git worktree add)