Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add silent support to Console transport stream #2296

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jhford-scout24
Copy link

I'm not sure why this doesn't exist in Winston, but it doesn't. In the file, I saw a comment

    // Remark: (jcrugzz) What is necessary about this callback(null, true) now
    // when thinking about 3.x? Should silent be handled in the base
    // TransportStream _write method?

And not knowing anything about how this library works internally, it does sound like if silent mode is specified at the Logger level, that all TransportStream instances should support this option.

@jhford-scout24
Copy link
Author

Same issue with the stream transport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant