Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query pagination when in desc order #2213

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

subnub
Copy link

@subnub subnub commented Oct 14, 2022

This is a fix when querying logs in descending order with pagination.

@wbt
Copy link
Contributor

wbt commented Oct 18, 2022

Looks like package-lock.json needs to be committed too, with just these updates.

@subnub
Copy link
Author

subnub commented Oct 24, 2022

@wbt thanks, added the package-lock

@wbt
Copy link
Contributor

wbt commented Oct 26, 2022

Thanks. By "just these updates" I meant commit only the diff lines that changed due to this commit, not "delete almost everything from package-lock."
At this point it might be easiest to check out the branch, revert the last change, reapply the addition of the two packages, and commit just the lines that changed in package-lock associated with those installations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants