New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: external inflight typescript files #6305
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! 🎉
|
Console preview environment is available at https://wing-console-pr-6305.fly.dev 🚀 Last Updated (UTC) 2024-05-24 20:32 |
BenchmarksComparison to Baseline ⬜⬜🟥⬜⬜⬜🟥⬜⬜⬜🟥⬜🟥
⬜ Within 1.5 standard deviations Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI. Results
Last Updated (UTC) 2024-04-24 21:05 |
af35e38
to
b0ee810
Compare
|
||
// @inflight | ||
|
||
let counter = new cloud.Counter(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's an issue with the Wing Console watch. It gets into an infinite reload loop because the inflight.ts file gets recreated and invalidates the watch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even when there's no change to the types? I specifically wanted to make sure the file isn't updated in that case so I'll look into it.
…rinsic-inflight
…rinsic-inflight
…rinsic-inflight
Fixes #6045
This PR introduces a new utility function
@inflight
. This allows you to create an inflight closure from an external file with specific lifts:By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.