New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sdk): switch function log format from text
to JSON
for AWS platforms
#5955
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! 🎉
|
Console preview environment is available at https://wing-console-pr-5955.fly.dev 🚀 Last Updated (UTC) 2024-05-21 19:13 |
BenchmarksComparison to Baseline ⬜⬜⬜⬜⬜🟥⬜⬜⬜⬜⬜⬜⬜
⬜ Within 1.5 standard deviations Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI. Results
Last Updated (UTC) 2024-05-21 19:08 |
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
@Chriscbr what do you think? |
It sounds handy, let's try it 👍 |
Hi @garysassano, |
I started an automated test on aws here |
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
The automated aws tests are failing: #5955 (comment) |
Hi, This PR has not seen activity in 20 days. Therefore, we are marking the PR as stale for now. It will be closed after 7 days. |
Hi @garysassano, can you please update from main? |
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
❌ Unstable Self-Mutation ❌Self-mutation has run twice in a row. There may be a something non-deterministic in the build or test process.
|
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
@garysassano math doesn't seem to work on AWS, can you please check? https://github.com/winglang/wing/actions/runs/8866141232/job/24343706916 |
I opened issue #6363, it should be fine once it gets fixed. |
Signed-off-by: monada-bot[bot] <monabot@monada.co>
Sdk spec tests are successful on tf-aws! it can be merged as soon as you'll fix the pr action |
Signed-off-by: monada-bot[bot] <monabot@monada.co>
A best practice when authoring Lambda functions is to use the Powertools for AWS Lambda Logger, which allows to emit structured logs in JSON format. However, even if you choose not to use Powertools, you can still take advantage of the JSON format to make navigating through your functions' logs much easier. This is true especially for the system logs, over which you have no direct control.
By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.