Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: better information for console visual map #5869

Closed
wants to merge 8 commits into from

Conversation

Chriscbr
Copy link
Contributor

@Chriscbr Chriscbr commented Mar 8, 2024

Trying out producing more detailed information in the SDK so the Wing Console can show better fidelity visual maps to users. Based on some discussions with @skyrpex and https://github.com/winglang/console-map-issues

Miscellaneous changes:

  • I started replacing many usages of supportedOps with liftMap within the SDK so we can deprecate supportedOps.

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

Copy link

github-actions bot commented Mar 8, 2024

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @eladb
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@monadabot
Copy link
Contributor

monadabot commented Mar 11, 2024

Console preview environment is available at https://wing-console-pr-5869.fly.dev 🚀

Last Updated (UTC) 2024-04-15 20:42

@monadabot
Copy link
Contributor

monadabot commented Mar 11, 2024

Benchmarks

Comparison to Baseline 🟥⬜🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 58ms±0.48 60ms±0.52 +2ms (+3%)🟥
functions_1.test.w -t sim 396ms±13.91 403ms±17.85 +7ms (+1.86%)⬜
functions_1.test.w -t tf-aws 810ms±6.2 827ms±5.38 +17ms (+2.14%)🟥
hello_world.test.w -t sim 393ms±5.75 404ms±15.06 +11ms (+2.76%)⬜
hello_world.test.w -t tf-aws 1499ms±7.89 1509ms±12.77 +10ms (+0.66%)⬜
jsii_big.test.w -t sim 2784ms±16.4 2776ms±12.46 -8ms (-0.3%)⬜
jsii_big.test.w -t tf-aws 2985ms±8.89 2989ms±10.65 +5ms (+0.15%)⬜
functions_10.test.w -t sim 486ms±9.73 483ms±9.79 -3ms (-0.53%)⬜
functions_10.test.w -t tf-aws 1998ms±12.61 2010ms±12.3 +12ms (+0.58%)⬜
jsii_small.test.w -t sim 365ms±2.57 365ms±4.76 +0ms (+0.1%)⬜
jsii_small.test.w -t tf-aws 603ms±6.31 602ms±5.14 -1ms (-0.2%)⬜
empty.test.w -t sim 359ms±3.75 368ms±5.85 +9ms (+2.57%)⬜
empty.test.w -t tf-aws 590ms±3.69 597ms±7.22 +6ms (+1.04%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 60ms 58ms 61ms 1ms 1ms
functions_1.test.w -t sim 403ms 388ms 471ms 18ms 25ms
functions_1.test.w -t tf-aws 827ms 811ms 840ms 5ms 8ms
hello_world.test.w -t sim 404ms 385ms 461ms 15ms 21ms
hello_world.test.w -t tf-aws 1509ms 1496ms 1555ms 13ms 18ms
jsii_big.test.w -t sim 2776ms 2753ms 2815ms 12ms 17ms
jsii_big.test.w -t tf-aws 2989ms 2963ms 3019ms 11ms 15ms
functions_10.test.w -t sim 483ms 464ms 504ms 10ms 14ms
functions_10.test.w -t tf-aws 2010ms 1967ms 2031ms 12ms 17ms
jsii_small.test.w -t sim 365ms 356ms 378ms 5ms 7ms
jsii_small.test.w -t tf-aws 602ms 591ms 616ms 5ms 7ms
empty.test.w -t sim 368ms 356ms 380ms 6ms 8ms
empty.test.w -t tf-aws 597ms 579ms 614ms 7ms 10ms
Last Updated (UTC) 2024-04-15 20:47

Signed-off-by: monada-bot[bot] <monabot@monada.co>
Copy link

Hi,

This PR has not seen activity in 20 days. Therefore, we are marking the PR as stale for now. It will be closed after 7 days.
If you need help with the PR, do not hesitate to reach out in the winglang community slack at winglang.slack.com.
Feel free to re-open this PR when it is still relevant and ready to be worked on again.
Thanks!

@github-actions github-actions bot removed the Stale label Apr 16, 2024
Copy link

github-actions bot commented May 6, 2024

Hi,

This PR has not seen activity in 20 days. Therefore, we are marking the PR as stale for now. It will be closed after 7 days.
If you need help with the PR, do not hesitate to reach out in the winglang community slack at winglang.slack.com.
Feel free to re-open this PR when it is still relevant and ready to be worked on again.
Thanks!

@github-actions github-actions bot added the Stale label May 6, 2024
@github-actions github-actions bot closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants