fix(compiler): lifting globals from inflight classes defined in preflight fails #5559

yoav-steinberg · 2024-01-28T09:07:47Z

Title matches Winglang's style guide
Description explains motivation and solution
Tests added (always)
Docs updated (only required for features)
Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

monadabot · 2024-01-28T09:07:58Z

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Discord.

Topic	Owner
Wing SDK and utility APIs	`@chriscbr`
Wing Console	`@ainvoner`, `@skyrpex`, `@polamoros`
JSON, structs, primitives and collections	`@hasanaburayyan`
Platforms and plugins	`@hasanaburayyan`
Frontend resources (website, react, etc)	`@tsuf239`
Language design	`@eladb`
VSCode extension and language server	`@markmcculloh`
Compiler architecture, inflights, lifting	`@yoav-steinberg`
Wing Testing Framework	`@tsuf239`
Wing CLI	`@markmcculloh`
Build system, dev environment, releases	`@markmcculloh`
Library Ecosystem	`@chriscbr`
Documentation	`@hasanaburayyan`
SDK test suite	`@tsuf239`
Examples	`@skorfmann`
Wing Playground	`@eladcon`

monadabot · 2024-01-28T09:15:07Z

Console preview environment is available at https://wing-console-pr-5559.fly.dev 🚀

Last Updated (UTC) 2024-03-10 09:41

monadabot · 2024-01-28T09:20:41Z

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜

Benchmark	Before	After	Change
version	58ms±0.33	59ms±0.43	+1ms (+1.38%)⬜
functions_1.test.w -t sim	544ms±18.05	521ms±4.05	-23ms (-4.21%)⬜
functions_1.test.w -t tf-aws	940ms±4.88	948ms±6.76	+8ms (+0.82%)⬜
jsii_small.test.w -t sim	487ms±4.76	491ms±7.09	+4ms (+0.92%)⬜
jsii_small.test.w -t tf-aws	711ms±2.87	721ms±16.98	+10ms (+1.42%)⬜
jsii_big.test.w -t sim	2920ms±8.3	2904ms±12.66	-15ms (-0.52%)⬜
jsii_big.test.w -t tf-aws	3121ms±11.79	3121ms±9.67	...
hello_world.test.w -t sim	514ms±3.32	518ms±4.15	+4ms (+0.79%)⬜
hello_world.test.w -t tf-aws	1640ms±10.22	1645ms±6.79	+5ms (+0.32%)⬜
empty.test.w -t sim	481ms±4.04	483ms±3.94	+2ms (+0.41%)⬜
empty.test.w -t tf-aws	701ms±3.3	707ms±5.93	+6ms (+0.9%)⬜
functions_10.test.w -t sim	598ms±10.19	597ms±9.58	-2ms (-0.29%)⬜
functions_10.test.w -t tf-aws	2226ms±9.49	2236ms±12.65	+10ms (+0.44%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results

name	mean	min	max	moe	sd
version	59ms	58ms	60ms	0ms	1ms
functions_1.test.w -t sim	521ms	512ms	531ms	4ms	6ms
functions_1.test.w -t tf-aws	948ms	931ms	960ms	7ms	9ms
jsii_small.test.w -t sim	491ms	477ms	508ms	7ms	10ms
jsii_small.test.w -t tf-aws	721ms	705ms	787ms	17ms	24ms
jsii_big.test.w -t sim	2904ms	2882ms	2935ms	13ms	18ms
jsii_big.test.w -t tf-aws	3121ms	3105ms	3147ms	10ms	14ms
hello_world.test.w -t sim	518ms	510ms	528ms	4ms	6ms
hello_world.test.w -t tf-aws	1645ms	1631ms	1662ms	7ms	9ms
empty.test.w -t sim	483ms	474ms	489ms	4ms	6ms
empty.test.w -t tf-aws	707ms	695ms	720ms	6ms	8ms
functions_10.test.w -t sim	597ms	576ms	611ms	10ms	13ms
functions_10.test.w -t tf-aws	2236ms	2208ms	2266ms	13ms	18ms

Last Updated (UTC) 2024-03-10 09:47

Signed-off-by: monada-bot[bot] <monabot@monada.co>

…nglang/wing into yoav/qualify_err_closure_lift

(inflight closures transformation now produces an inflight class)

libs/wingc/src/type_check.rs

…LifeableModuleType`

Because the type system can't distinguish between a closure class (which needs to be lifted) and a regular function type... Also lift on reference and not all call, by assuming a ref to a closure will actually call it later on, we can correctly lift (and setup permissions) for closures stored in collections (for example). This is a special exception to our qualification rules, since closures only have a single method (`handle`) so we can implicitly qualify it.

so we're sure the type is lifted

Signed-off-by: monada-bot[bot] <monabot@monada.co>

…nglang/wing into yoav/qualify_err_closure_lift

Signed-off-by: monada-bot[bot] <monabot@monada.co>

…ames)

this should resolve issue with lifting the type base class of inflight classes.

…r types lifts

Signed-off-by: monada-bot[bot] <monabot@monada.co>

…nglang/wing into yoav/qualify_err_closure_lift

yoav-steinberg added 2 commits January 28, 2024 11:05

wip

2ec7bb9

wip

8e9de7d

yoav-steinberg changed the title ~~fix(compiler): we fail to detect errors qualifying inflight closure lifts~~ fix(compiler): ail to detect errors qualifying inflight closure lifts Jan 28, 2024

monadabot and others added 2 commits January 28, 2024 11:21

Merge branch 'main' into yoav/qualify_err_closure_lift

33f8765

chore: self mutation (build.diff)

6b595d7

Signed-off-by: monada-bot[bot] <monabot@monada.co>

monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Jan 28, 2024

yoav-steinberg changed the title ~~fix(compiler): ail to detect errors qualifying inflight closure lifts~~ fix(compiler): fail to detect errors qualifying inflight closure lifts Jan 28, 2024

yoav-steinberg linked an issue Jan 28, 2024 that may be closed by this pull request

closures array not lifted correctly #5527

Closed

yoav-steinberg added 4 commits January 28, 2024 14:21

store whether expr is callee in AST instead of during visiting

10f0670

Merge branch 'yoav/qualify_err_closure_lift' of https://github.com/wi…

6a366e4

…nglang/wing into yoav/qualify_err_closure_lift

wip: lift inflight classes (defined preflight)

f5a6ac4

deduce class phase in type system based on class definitions

97d10f5

(inflight closures transformation now produces an inflight class)

Chriscbr reviewed Feb 7, 2024

View reviewed changes

libs/wingc/src/type_check.rs Outdated Show resolved Hide resolved

yoav-steinberg added 4 commits February 12, 2024 14:41

better handling of lifting host agnostic types

4e82c45

correctly handle onLift of synthetic resource type generated by `to…

5f7ddb6

…LifeableModuleType`

treat class phase based on code modifier (chuck auto-phase idea for now)

3942817

yoav-steinberg removed a link to an issue Feb 12, 2024

closures array not lifted correctly #5527

Closed

visit all udt refs before qualifying inflight type lifts

36b89b8

so we're sure the type is lifted

yoav-steinberg linked an issue Feb 12, 2024 that may be closed by this pull request

Unable to capture preflight object from within an inflight class #2730

Open

yoav-steinberg added 7 commits February 16, 2024 16:47

Qualify inflight class usage even when type not explicitly lifted

d3ef0cc

test qualify inflight type when not available in scope

f8dd462

test

cb94d46

cleanup

b833982

generate less class aliases (smaller snapshot diff)

9fee686

added test

463568c

typo

916b54f

yoav-steinberg and others added 19 commits February 16, 2024 18:50

test static method lifts of inflight class

0b149b6

Merge branch 'main' into yoav/qualify_err_closure_lift

7dc5856

fix after merge

48ecb71

Merge branch 'main' into yoav/qualify_err_closure_lift

12b54e2

chore: self mutation (e2e-1of2.diff)

c8c8678

Signed-off-by: monada-bot[bot] <monabot@monada.co>

chore: self mutation (e2e-2of2.diff)

118510e

Signed-off-by: monada-bot[bot] <monabot@monada.co>

lint

2d436f0

Merge branch 'yoav/qualify_err_closure_lift' of https://github.com/wi…

cb749b8

…nglang/wing into yoav/qualify_err_closure_lift

Merge branch 'main' into yoav/qualify_err_closure_lift

e3dd5d0

chore: self mutation (build.diff)

d6f0242

Signed-off-by: monada-bot[bot] <monabot@monada.co>

No need to store TypeRef in lift qualifications (we use unique type n…

eb9205b

…ames)

use dummy object lift map for inflight class isntead of type lift map

4e865a6

this should resolve issue with lifting the type base class of inflight classes.

Merge branch 'main' into yoav/qualify_err_closure_lift

e9c883c

fix after merge

7a45ea8

remove leftover of experiment generating inflight_init lifitng map fo…

0f0b8cd

…r types lifts

Merge branch 'main' into yoav/qualify_err_closure_lift

e98b310

chore: self mutation (build.diff)

2dbf12a

Signed-off-by: monada-bot[bot] <monabot@monada.co>

chore: self mutation (e2e-1of2.diff)

fd71b88

Signed-off-by: monada-bot[bot] <monabot@monada.co>

chore: self mutation (e2e-2of2.diff)

0db70d9

Signed-off-by: monada-bot[bot] <monabot@monada.co>

yoav-steinberg changed the title ~~fix(compiler): fail to detect errors qualifying inflight closure lifts~~ fix(compiler): lifting globals from inflight classes defined in preflight fails Feb 22, 2024

yoav-steinberg added 2 commits March 10, 2024 11:33

inflight class singletons are defined per root node and not globaly

8e90a4f

Merge branch 'yoav/qualify_err_closure_lift' of https://github.com/wi…

cdf4b66

…nglang/wing into yoav/qualify_err_closure_lift

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(compiler): lifting globals from inflight classes defined in preflight fails #5559

fix(compiler): lifting globals from inflight classes defined in preflight fails #5559

yoav-steinberg commented Jan 28, 2024 •

edited

monadabot commented Jan 28, 2024 •

edited by revitalbarletz

monadabot commented Jan 28, 2024 •

edited

monadabot commented Jan 28, 2024 •

edited

fix(compiler): lifting globals from inflight classes defined in preflight fails #5559

Are you sure you want to change the base?

fix(compiler): lifting globals from inflight classes defined in preflight fails #5559

Conversation

yoav-steinberg commented Jan 28, 2024 • edited

monadabot commented Jan 28, 2024 • edited by revitalbarletz

monadabot commented Jan 28, 2024 • edited

Last Updated (UTC) 2024-03-10 09:41

monadabot commented Jan 28, 2024 • edited

Benchmarks

Last Updated (UTC) 2024-03-10 09:47

yoav-steinberg commented Jan 28, 2024 •

edited

monadabot commented Jan 28, 2024 •

edited by revitalbarletz

monadabot commented Jan 28, 2024 •

edited

monadabot commented Jan 28, 2024 •

edited