[WIP] feat: cloud.Check (sdk modules written in Wing) #5427
Conversation
|
Thanks for opening this pull request! 🎉
|
| if source_path == self.sdk_in_wing_dir { | ||
| let mut cloud_ns = self | ||
| .types | ||
| .libraries | ||
| .lookup_nested_str("@winglang/sdk.cloud", None) | ||
| .unwrap() | ||
| .0 | ||
| .as_namespace_ref() | ||
| .unwrap(); | ||
| for child_env in &child_envs { | ||
| cloud_ns.envs.push(*child_env); | ||
| } | ||
| } |
There was a problem hiding this comment.
This code inside type_check_dir translates roughly to "if I'm type checking a directory, and the directory happens to be the special one bundled in the wing compiler, insert all of my types into the cloud namespace"
|
Console preview environment is available at https://wing-console-pr-5427.fly.dev 🚀 Last Updated (UTC) 2024-01-06 00:07 |
BenchmarksComparison to Baseline ⬜
⬜ Within 1.5 standard deviations Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI. Results
Last Updated (UTC) 2024-01-06 00:12 |
Signed-off-by: monada-bot[bot] <monabot@monada.co>
monadabot
added
the
⚠️ pr/review-mutation
eladb
removed
the
⚠️ pr/review-mutation
| (await $handler()); | ||
| } | ||
| catch ($error_e) { | ||
| const e = $error_e.message; |
There was a problem hiding this comment.
Why did these snapshots have to change?
|
Hi, This PR has not seen activity in 20 days. Therefore, we are marking the PR as stale for now. It will be closed after 7 days. |
|
@Chriscbr any updates on this? Would be awesome to be able to get this merged :-) |
WIP - type checking works, but the emitted JS code doesn't work (the compiler doesn't yet know to emit the code for
cloud.Checkdifferently than the other SDK modules)Closes #4810
Checklist
pr/e2e-fulllabel if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.