Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nix): add semicolon after assignments #455

Closed
wants to merge 1 commit into from

Conversation

f1rstlady
Copy link
Contributor

@f1rstlady f1rstlady commented May 9, 2024

In the Nix language, every assignment is introduced with an equals sign and closed by a semicolon. This rule automatically inserts a semicolon if = has been entered.

Apparently, the ts_conds.is_not_ts_node_comment() predicate is ignored. Can you help me to get it right?

@f1rstlady f1rstlady force-pushed the nix-assignment-rule branch 2 times, most recently from d8a0a18 to 8891529 Compare May 10, 2024 19:30
@windwp
Copy link
Owner

windwp commented May 16, 2024

you need to input the treesitter node name to function is_not_ts_node_comment

i will not merge because it is not an common case. may be you can add it on your config

@windwp
Copy link
Owner

windwp commented May 16, 2024

you need to input the tree sitter node name to function is_not_ts_node_comment

i will not merge because it is not an common case. may be you can add it on your config

@f1rstlady
Copy link
Contributor Author

f1rstlady commented May 16, 2024

you need to input the tree sitter node name to function is_not_ts_node_comment

But is_not_ts_node_comment does not accept any arguments. Or do you mean is_not_ts_node_comment()(info)? I tested it but it did not work either.

i will not merge because it is not an common case. may be you can add it on your config

Ok. I thought you would like to collect sensible rules to build up a knowledge base.

@windwp
Copy link
Owner

windwp commented May 18, 2024

but your rule need to remap a space key. even it fast but i don't want to check that everytime i type space key.

you can add it on wiki page it has some custom rule

@f1rstlady
Copy link
Contributor Author

but your rule need to remap a space key. even it fast but i don't want to check that everytime i type space key.

Good point.

you can add it on wiki page it has some custom rule

Ok, good idea.

@f1rstlady f1rstlady closed this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants