Do not move right when char is not valid for rule #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bew
commented
May 16, 2023
tests/nvim-autopairs_spec.lua
Outdated
| end, | ||
| key = [[(]], | ||
| before = [[$|$]], | ||
| after = [[$(|)$]] |
There was a problem hiding this comment.
This test does not pass, the ( does not pair but I don't understand why..
Adding some debugs, it seems the can_pair call of ( returns false in this case, but looking at the code I don't understand why 馃
@windwp any insight?
Fail || autopairs test do not move right on non-end-pair char
./tests/test_utils.lua:67:
text error: do not move right on non-end-pair char
Expected objects to be the same.
Passed in:
(string) '$($'
Expected:
(string) '$()$'
stack traceback:
./tests/test_utils.lua:67: in function 'compare_text'
./tests/test_utils.lua:156: in function <./tests/test_utils.lua:95>
There was a problem hiding this comment.
$ is include on default value ignored_next_char so that test case will not work.
There was a problem hiding this comment.
That finally explains it, thanks! I used another symbol for that test.
bew
changed the title
Closed
bew
force-pushed
the
fix-move-with-other-pairs
branch
from
0f3e6bd
to
37383a1
Compare
bew
force-pushed
the
fix-move-with-other-pairs
branch
from
37383a1
to
8cda6c0
Compare
|
I rebased this PR for a clean merge if you want. |
|
Ok thanks 馃憤 |
bew
added a commit
to bew/dotfiles
that referenced
this pull request
May 30, 2023
bew
added a commit
to bew/dotfiles
that referenced
this pull request
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was that when checking if we should move right, the current char was never checked to be valid for the current rule.
Fixes #331
I didn't manage to run the tests locally, this is why I made many commits & used the CI to test 馃憖
Only 1 test is failing, and I don't understand why, see the comment below