fix: handle primes properly in text filetypes (#345) #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank to fix this. you don't need to check filetype just checking it is a single quote and have word before it. |
|
Hi, thanks for your reply. To be honest I'm not sure how to add and run test properly for this project and I'll be quite busy in the following month. Could you help me with the test cases? Or I can add them when I have time. |
In text files (markdown, tex, text, ...) primes should not be considered
as opening single quotes, consider the following example:
Ben's friends say: '...'
The first single quote should not be considered as an opening single
quote.
In this commit we treat single quotes directly following a word
character as a prime. This only applies to text filetypes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In text files (markdown, tex, text, ...) primes should not be considered as opening single quotes, consider the following example:
The first single quote should not be considered as an opening single quote.
In this commit we treat single quotes directly following a word character as a prime. This only applies to text filetypes, as programming languages usually have stricter syntax and won't allow this.