Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable windup's tests on Windows and MacOS #1671

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

mrizzi
Copy link
Member

@mrizzi mrizzi commented May 24, 2023

The goal is to check issue https://issues.redhat.com/browse/WINDUP-3881 will happen when running ZipExportingTest on Windows.

Changes:

  • ReferenceResolvingVisitor.extractDefinitionLine method made 'new line marker' indipendent
  • JavaASTReferenceResolverTest: same test Java classes in java-ast/tests/src/test/resources have different sizes on different OSes
  • ExecutionStatisticsTest: replace Thread.sleep with busy wait because Linux and Windows have different interrupt perios (ref. https://stackoverflow.com/a/11498647)
  • Tests: refactored FileUtils.deleteDirectory in finally blocks to FileUtils.deleteQuietly due to issues with deletions on Windows (which would be worth being properly investigated rather than being workarounded)
  • Switch to shell: pwsh to consistently retrieve the CHROMEWEBDRIVER env variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants