Winduprule 363 and 142 spring remote services #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
September 27, 2018 11:31
…orter bean and the Class from the implementation bean
created Arquillian test for Spring RMI rule
Added a POC of including info in a different section ( JAX-WS )
…operly work Added all non RMI services to JaxWS services while waiting the category to be put
…rvice Reports and TechnologyIdentified to show on Technology Usage report
…eport template ) Added new Model and Service to cover Spring Remote Services Modified the creation of the Remote Services report to consider new Model
…-on-services-report
…duplicated code Created rule to discover Spring Rest services
…bean of a remote service in any XML file
…o compile because of the dependent projects
|
I haven't been able to run the Test classes because of problems with my local Arquillian configuration but I'm happy with the code. If someone else can certify the tests then great. |
added 4 commits
December 3, 2018 11:21
set always the implementation class from outside, or find it as it was before
…s considering the new bean definition
|
@mrizzi I've reviewed and tested the latest changes successfully so this is ready to merge as far as I'm concerned |
added 19 commits
January 21, 2019 10:51
…nceModel inject returnType on the ClassReference on the analyze process use returnType on the DiscoverySpringBeanMethodAnnotationsRuleProvider
…, otherwise are excluded from the analysis
changed test files to packages out of the regular ones added annotation to the interested types
PhilipCattanach
added
On Hold
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR With the Spring Remote Services features :
Also contains Spring REST Services detection on Java classes
To allow this it was needed to create rules to detect Spring Beans on Java classes and being added to the SpringBeanService
Jira tickets covered :
WINDUPRULE-363
WINDUPRULE-142