Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XmlFileXpathValidator - create the snippet properly - just from the n… #1189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OndraZizka
Copy link
Contributor

…ode, not it's child nodes. Plus some small refactoring.

…ode, not it's child nodes. Plus some small refactoring.
@jsight
Copy link
Member

jsight commented Sep 26, 2017

What problem does this solve?

@OndraZizka
Copy link
Contributor Author

  1. It doesn't show irrelevant content in places where the snippet is displayed.
  2. Excessive log output, making it hard to find the relevant information in it.

@jsight
Copy link
Member

jsight commented Sep 28, 2017

I will need to see some examples of where that happens in order to understand that.

@OndraZizka
Copy link
Contributor Author

Check the documentation of the original length code. It gives a description of the element object rather than the XML code as assumed in the code. It's a buggy code.
Then the second part is that as the snippet, the whole XML tree is taken. My change only takes the relevant element's serialization length. Not perfect, not exact, but better than the basically random length or the wole XML subtree currently used.

@windupgithubbot1
Copy link

Can one of the admins verify this patch?

2 similar comments
@windupgithubbot1
Copy link

Can one of the admins verify this patch?

@windupgithubbot1
Copy link

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants