feat(frontend): allows to specify column order for rich display #3709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying windmill with
|
| Latest commit: |
b48c85f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cc9fa8ba.windmill.pages.dev |
| Branch Preview URL: | https://hugo-win-92-table-display-co.windmill.pages.dev |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to b48c85f in 1 minute and 6 seconds
More details
- Looked at
296lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/src/lib/components/DisplayResult.svelte:72
- Draft comment:
The check!Array.isArray(result)inisObjectOfArraysfunction seems unnecessary since the inputresultis already expected to be an object (not an array). Consider simplifying the function by removing this check. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_TMKD0UVu5Z4b5jjv
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
⌛ 3 days left in your free trial, upgrade for $20/seat/month or contact us.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
windmill-labs/windmilldocs#608
Summary:
Enhances the
DisplayResult.sveltecomponent by adding new data handling capabilities and optimizing the rendering logic for various data types.Key points:
DisplayResult.svelteto enhance data handling and display.Generated with ❤️ by ellipsis.dev