Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart scan #2200

Closed
wants to merge 9 commits into from
Closed

Smart scan #2200

wants to merge 9 commits into from

Conversation

nickmayer
Copy link
Contributor

Reworked the auto leveler to be a lot smarter about scanning resulting in a huge speedup. Also change UI to make it a lot less likely you'll forget to apply your scanned heightmap to your gcode.

@nickmayer
Copy link
Contributor Author

I see there are some tests failing...not too surprising since I can't actually run the tests with my setup (MSYS on Win10). What is the "official" setup used by the devs? I haven't had any luck getting mvn to work without skipping tests (mvn install -Dmaven.test.skip=true) on either Win10 MSYS, Win10 WSL2, or an Ubuntu VM.

@nickmayer nickmayer force-pushed the smart-scan branch 2 times, most recently from d49a74c to 6cf1289 Compare April 25, 2023 01:53
Scan more intelligently and use a separate retract value to speed things up significantly. Automatically apply the command processor if there is valid data.
@breiler
Copy link
Collaborator

breiler commented Jul 1, 2023

Sorry for the lack of response on this. I'm currently rebuilding my machine and have ordered a decent probe to test this out. I'll take care of the merge conflict.

@breiler
Copy link
Collaborator

breiler commented Aug 2, 2023

I have now finally tried this and it seems to work fine. I needed to revert the changes to the CommandProcessorList to not break its behavior described in my previous comment.

There was also a place where you added a double value comparison. This did in certain cases not work because double values are not exact or that there could be rounding errors reported from the controller. I had to add a double compare function with a minimum error threshold.

I was thinking of creating a PR to your branch, but it got pretty messy with all changes coming from master. So I'll close this and create a new PR.

Thanks for your contribution!

@breiler breiler closed this Aug 2, 2023
@breiler breiler mentioned this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants