-
-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smart scan #2200
Smart scan #2200
Conversation
I see there are some tests failing...not too surprising since I can't actually run the tests with my setup (MSYS on Win10). What is the "official" setup used by the devs? I haven't had any luck getting |
…or file separators
…without necessarily needing to understand the other commands on the line
… do things like re-add command processors
d49a74c
to
6cf1289
Compare
Scan more intelligently and use a separate retract value to speed things up significantly. Automatically apply the command processor if there is valid data.
Sorry for the lack of response on this. I'm currently rebuilding my machine and have ordered a decent probe to test this out. I'll take care of the merge conflict. |
I have now finally tried this and it seems to work fine. I needed to revert the changes to the There was also a place where you added a double value comparison. This did in certain cases not work because double values are not exact or that there could be rounding errors reported from the controller. I had to add a double compare function with a minimum error threshold. I was thinking of creating a PR to your branch, but it got pretty messy with all changes coming from master. So I'll close this and create a new PR. Thanks for your contribution! |
Reworked the auto leveler to be a lot smarter about scanning resulting in a huge speedup. Also change UI to make it a lot less likely you'll forget to apply your scanned heightmap to your gcode.