Update ImportAzureApplicationGateway.ps1 for Az module an password security

[valdearg]

AzureRM has been generally deprecated in favour of the Az module, this is largely just a drop-in replacement for commands.

For encoding passwords with the new method we need to use -Force and -AsPlainText

https://learn.microsoft.com/en-us/azure/application-gateway/renew-certificates

[webprofusion-chrisc]

Wouldn't this break the script for existing users?

[valdearg]

I've been having a bit of a think on this and just sharing my thoughts.

1. The Az module is a fairly "drop-in" replacement, however this requires intervention by the user to apply, even if we were to place the Az module user installation into the script. It may also just generally not possible to install automatically in environments.

2. AzureRM has been deprecated for quite a few years at this point. There is an option to enable legacy aliases within the Az module which means scripts won't need to be updated, but it's not the best way around things in production.

3. A safer option may be to move these changes into a ImportAzureApplicationGateway.v2.ps1 instance, this means that users who are using the AzureRM version would not be affected and new users would be able to choose which version to use.

4. I wouldn't say no to updating the auth option also in a future pull request, there's a new option of authenticating which may make it easier for setup in an automated environment. Of course, making it optional.

[WouterTinus]

I think making this a .v2 version of the script would be wise.