Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Proterozoic and Archaean HEX codes for periods, eras and eons. #62

Closed
wants to merge 3 commits into from

Conversation

richardstockey
Copy link

The pre-Phanerozoic colour codes were previously a series of pinks that did not correspond to the geologic timescale. I have here updated all instances I could find to match international geologic timescale standards for the Proterozoic and Archaean. HEX codes used from https://github.com/crimeacs/Geochronological_Colors/blob/master/Geochronological_scale_HEX.pdf. I have visually confirmed that this matches colours used in ICS and GSA timescale charts.

@willgearty
Copy link
Owner

willgearty commented Mar 21, 2024

Thanks for putting this together @richardstockey, making sure these colors are correct is definitely important. At the moment, I periodically pull the timescale data (using this script) from the Macrostrat API (e.g., international periods), which is usually pretty up-to-date with the ICS changes. However, it appears that they have the wrong colors in the API for lots of these older time periods as you've discovered and remedied here. This PR is great, but I'm worried that I'll just end up overriding these changes the next time I update the timescale from the Macrostrat API, so we probably want to fix this in their API first and then update deeptime's data from that. Maybe @davenquinn or @cambro could help us out or point us in the right direction?

@cambro
Copy link

cambro commented Mar 21, 2024

We at Macrostrat use custom colors for the Neoproterozoic and Mesoproterozoic because in map-based renditions of the colors are visually very difficult to distinguish from the Paleogene. You can always access the originally defined colors with the API parameter "true_colors=true", like: https://macrostrat.org/api/defs/intervals?timescale=international%20periods&true_colors=true

@willgearty
Copy link
Owner

Ah, that would do it, thank you so much for pointing that out @cambro!

@willgearty
Copy link
Owner

@richardstockey I've updated the built-in dataframes using this new Macrostrat API option. Could you check out the github development version and let me know if that fixes the problem?
Before:
image
After:
image

@willgearty
Copy link
Owner

@richardstockey are you satisfied with my recent additions?

@willgearty
Copy link
Owner

I'm going to close this in favor of 5307477.

@willgearty willgearty closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants