fix: enable SNI #282
Merged
fix: enable SNI #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I confirm it works fine, could this be merged ? cc @bcardiff |
|
Merged! Thanks for the nudge |
|
Thanks @conradludgate! (and also thanks @bcardiff for getting to this before I did) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃憢 At Neon, we use SNI to know which database endpoint is being requested to connect to. Our fallback options are using
optionswhich this library also doesn't support, or using cleartext passwords and encoding the database endpoint into the password. See https://neon.tech/docs/connect/connection-errors#the-endpoint-id-is-not-specifiedReading https://forum.crystal-lang.org/t/specifying-the-sni-hostname-for-an-openssl-context/3872 it seems like enabling SNI wasn't too challenging. Testing locally it does seem to work.