[WFLY-16555] Add tests and docs for HTTP Digest persisted in HTTP session #16897
Conversation
github-actions
bot
added
the
deps-ok
docs/src/main/asciidoc/_elytron/migrate/SSL_with_Client_Cert_Migration.adoc
Outdated
Show resolved
Hide resolved
...c/test/java/org/jboss/as/test/integration/domain/suites/HttpSessionDigestDomainTestCase.java
Outdated
Show resolved
Hide resolved
bstansberry
added
core-upgrade-needed
Skyllarr
force-pushed
the
WFLY-16555-test-and-docs
branch
from
15d6137
to
734b703
Compare
| @@ -93,8 +93,8 @@ server factories. | |||
| the SASL server factory is an aggregation of other SASL server | |||
| factories. | |||
|
|
|||
| |configurable-http-server-mechanism-factory |A SASL server factory | |||
| definition where the SASL server factory is an aggregation of other SASL | |||
| |configurable-http-server-mechanism-factory |An HTTP server factory | |||
There was a problem hiding this comment.
Since this change is unrelated to this RFE and would be good to get included soon, what do you think about creating a good first issue for this update instead?
There was a problem hiding this comment.
@Skyllarr I think this comment still needs to be addressed.
Skyllarr
force-pushed
the
WFLY-16555-test-and-docs
branch
from
734b703
to
4fe8c41
Compare
| @@ -164,6 +164,24 @@ Resulting in: - | |||
| </subsystem> | |||
| ---- | |||
|
|
|||
| If you want to use the HTTP DIGEST authentication mechanism with a load balancer, you can add the following property to the HTTP server mechanism factory: | |||
There was a problem hiding this comment.
I am thinking this may need a bit more detail to it.
If they have multiple app server instances in front of a load balancer they also need their HTTP Session to be replicated otherwise the same issue would remain. Maybe there should also be a bit more "why" in the docs.
| import java.util.stream.Collectors; | ||
|
|
||
| @RunWith(Arquillian.class) | ||
| public class HttpSessionDigestTestCase { |
There was a problem hiding this comment.
Please relocate this test here (alongside clustering tests for other auth mechanisms):
https://github.com/wildfly/wildfly/tree/main/testsuite/integration/clustering/src/test/java/org/jboss/as/test/clustering/cluster/web/authentication
| @Test | ||
| @RunAsClient | ||
| @InSequence(1) | ||
| public void setup() throws Exception { |
There was a problem hiding this comment.
N.B. Once migrated to clustering testsuite, this method should go away.
| configureServerWithFSRealmAndSessionDigestProperty(new CLIWrapper(LOCALHOST, MGMT_PORT_NODE_1, true)); | ||
| configureServerWithFSRealmAndSessionDigestProperty(new CLIWrapper(LOCALHOST, MGMT_PORT_NODE_2, true)); |
There was a problem hiding this comment.
Replace this with a ManagementServerSetupTask.
https://issues.redhat.com/browse/WFLY-16555
Requires: ELY-2359 , PR: wildfly-security/wildfly-elytron#1909