Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildfly mini serie #595

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

tommaso-borgato
Copy link

@tommaso-borgato tommaso-borgato commented Apr 22, 2024

#596

This mini-serie just aims at filling the gap we have at the very beginning of our learning path with WF+Microservices+Containers;

We aim at improving documentation for Wildfly/EAP and creating a series of blog-posts for users/customers. i.e. produce a step by step mini-serie which can be used to create a POC with Wildfly/EAP microservices running on Kubernetes; this would help new adopters who want quickly do a POC with the features they want (we start with basic features and, perhaps, add more later)


include::{includedir}/_prerequisites.adoc[]

* link:/get-started[Getting Started with WildFly]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be official step in the guide.


== Maven Project

In link:/get-started[Getting Started with WildFly], we created a simple Jakarta EE application Maven Project containing a link:https://jakarta.ee/specifications/restful-ws/[Jakarta RESTful Web Service]: we'll pick up from there;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, here. Just changing the wording to something like go through "Getting Started with WildFly"....

</goals>
</execution>
</executions>
</plugin>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use Wildfly Glow here? I find it much more user friedly.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer not to use glow, since its usability was under discussion... it might be yet another post in this mini-serie

include::{includedir}/_prerequisites.adoc[]

* link:/get-started[Getting Started with WildFly]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing "docker/podman" mentioned in prerequisites.


NOTE: we explicitly mapped port `8080` in the container to port `8080` on the HOST (your PC); we also mapped port `9990` in the container to port `9990` on the HOST to expose the Liveness, Readiness and Startup Probes;

=== Check the application
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about duplicating the steps to check the when they're the same as above. Maybe it could be mentioned that it can be checked the same way as above (+link)


=== pom.xml

Since we are going to deploy on link:https://kubernetes.io/[Kubernetes], we need to add some features that are necessary when running on link:https://kubernetes.io/[Kubernetes]: link:https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/[Liveness, Readiness and Startup Probes];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could be mentioned here that Kubernetes will be needed in the 2.part of the gude and it's not necessary to install it at this point.

In this guide, you will learn how-to run the Docker Image we built in link:simple-microservice-part1[{simple-microservice-part1}] on Kubernetes.

include::{includedir}/_prerequisites.adoc[]
* You have completed link:simple-microservice-part1.adoc[Create a JAX-RS application using Bootable Jar - part one: bare metal]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would deserve to add step with link to guide how to install Kubernetes intance locally which would be used in next steps. I think it's quite a big thing so it might be another step in the guide.


=== Quay.io

You can skip this step in case you prefer to re-use the `quay.io/{quay-io-account-name}/{docker-image-name}` Docker Image, that we already pushed to link:quay.io[quay.io] in the `{quay-io-account-name}` account;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not mention here personal accounts. Better will be to use something general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants