[WFLY-19261] microprofile-lra Quickstarts should have a root webpage similar to helloworld #897
Conversation
|
Hi @sudeshnas93. Thanks for your PR. I'm waiting for a wildfly member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
|
||
| @Path("/") | ||
| @ApplicationScoped | ||
| public class applicationlra { |
There was a problem hiding this comment.
Nope, that's not how classes are named in Java :-)
There was a problem hiding this comment.
Hey, thanks for pointing it out. Fixed it. :)
microprofile-lra/README.adoc
Outdated
|
|
||
| [source] | ||
| ----- | ||
| Hello! Microprofile-Lra Quickstart deployed successfully! You can find the available operations in the included README file. |
There was a problem hiding this comment.
I think this should be MicroProfile LRA
There was a problem hiding this comment.
Let's revert and not do any README changes wrt adding a root deployment page, please. As I said in the jaxrs-client PR we should later workout a common strategy for documenting this in a /shared-docs included section.
There was a problem hiding this comment.
Reverted the readme changes.
| @GET | ||
| @Produces(MediaType.TEXT_PLAIN) | ||
| public String getRootResponse() { | ||
| return "Hello! Microprofile-Lra Quickstart deployed successfully! You can find the available operations in the included README file."; |
There was a problem hiding this comment.
Please use instead a static index.html like you did for jaxrs-client.
As for the content, please always use the exact quickstart's path, in this case "microprofile-lra"
There was a problem hiding this comment.
Please review, I have used a static index.html page instead.
|
|
||
| [source] | ||
| ----- | ||
| Hello! Microprofile-Lra Quickstart deployed successfully! You can find the available operations in the included README file. |
There was a problem hiding this comment.
please revert this change, it would add the new content to all quickstart READMEs
sudeshnas93
force-pushed
the
WFLY-19261
branch
5 times, most recently
from
26e40e2
to
30f586f
Compare
| @@ -25,6 +25,6 @@ | |||
| import jakarta.ws.rs.ApplicationPath; | |||
| import jakarta.ws.rs.core.Application; | |||
|
|
|||
| @ApplicationPath("/") | |||
| @ApplicationPath("/rest") | |||
There was a problem hiding this comment.
/ needs to be reserved for the root web page as required. Changed to /rest because there can be path conflicts if we don't change the rest endpoints path to something else other than /
…similar to helloworld
Issue: https://issues.redhat.com/browse/WFLY-19261
Linked Issue: https://issues.redhat.com/browse/WFLY-19075