Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFLY-19229 The OpenAPI BasicRuntimeIT is ineffective and passes even … #894

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rhusar
Copy link
Member

@rhusar rhusar commented Apr 11, 2024

…on non-OpenAPI compliant runtime

Fixes
https://issues.redhat.com/browse/WFLY-19229

@rhusar rhusar requested a review from emmartins as a code owner April 11, 2024 14:20
@rhusar
Copy link
Member Author

rhusar commented Apr 11, 2024

The whole BasicRuntimeIT is a mess as well... it's being overriden (http://localhost:8080/) but in the templates this forms URIs without the context path - and since it only chcecks for 200, it would pass anwyay...

@rhusar
Copy link
Member Author

rhusar commented Apr 11, 2024

The whole BasicRuntimeIT is a mess as well... it's being overriden (http://localhost:8080/) but in the templates this forms URIs without the context path - and since it only chcecks for 200, it would pass anwyay...

Will open a Jira when Jira is back online.

@emmartins
Copy link
Contributor

emmartins commented Apr 11, 2024 via email

@emmartins
Copy link
Contributor

emmartins commented Apr 11, 2024 via email

@rhusar
Copy link
Member Author

rhusar commented Apr 11, 2024

FYI the server host is overriden on server provisioning/bootable jar environment, and on those the app is deployed at root context, i.e. thus no context path

On Thu, 11 Apr 2024 at 16:50, Radoslav Husar @.> wrote: The whole BasicRuntimeIT is a mess as well... it's being overriden ( http://localhost:8080/) but in the templates this forms URIs without the context path - and since it only chcecks for 200, it would pass anwyay... Will open a Jira when Jira is back online. — Reply to this email directly, view it on GitHub <#894 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEDY6CUDHIBTLR7MA57SVLY42WLXAVCNFSM6AAAAABGCM7BKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJQGAYDONZUHA . You are receiving this because your review was requested.Message ID: @.>

Gotcha, good point. So only affecting this specific scenario.

…on non-OpenAPI compliant runtime

Fix BasicRuntimeIT does not add /context-path when SERVER_HOST/server.host is overriden.
Copy link

openshift-ci bot commented Apr 11, 2024

@rhusar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/wildfly-quickstart-e2e 06cb7d8 link true /test wildfly-quickstart-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rhusar rhusar requested a review from pferraro April 20, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants