-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WFLY-19229 The OpenAPI BasicRuntimeIT is ineffective and passes even … #894
base: main
Are you sure you want to change the base?
Conversation
The whole BasicRuntimeIT is a mess as well... it's being overriden (http://localhost:8080/) but in the templates this forms URIs without the context path - and since it only chcecks for 200, it would pass anwyay... |
Will open a Jira when Jira is back online. |
FYI the server host is overriden on server provisioning/bootable jar
environment, and on those the app is deployed at root context, i.e. thus no
context path
…On Thu, 11 Apr 2024 at 16:50, Radoslav Husar ***@***.***> wrote:
The whole BasicRuntimeIT is a mess as well... it's being overriden (
http://localhost:8080/) but in the templates this forms URIs without the
context path - and since it only chcecks for 200, it would pass anwyay...
Will open a Jira when Jira is back online.
—
Reply to this email directly, view it on GitHub
<#894 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEDY6CUDHIBTLR7MA57SVLY42WLXAVCNFSM6AAAAABGCM7BKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJQGAYDONZUHA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Wrt just checking 200, some QS have opted also to test the content, and for
sure I think that’s a good decision ;-)
…On Thu, 11 Apr 2024 at 16:52, Eduardo Martins ***@***.***> wrote:
FYI the server host is overriden on server provisioning/bootable jar
environment, and on those the app is deployed at root context, i.e. thus no
context path
On Thu, 11 Apr 2024 at 16:50, Radoslav Husar ***@***.***>
wrote:
> The whole BasicRuntimeIT is a mess as well... it's being overriden (
> http://localhost:8080/) but in the templates this forms URIs without the
> context path - and since it only chcecks for 200, it would pass anwyay...
>
> Will open a Jira when Jira is back online.
>
> —
> Reply to this email directly, view it on GitHub
> <#894 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAEDY6CUDHIBTLR7MA57SVLY42WLXAVCNFSM6AAAAABGCM7BKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANJQGAYDONZUHA>
> .
> You are receiving this because your review was requested.Message ID:
> ***@***.***>
>
|
Gotcha, good point. So only affecting this specific scenario. |
…on non-OpenAPI compliant runtime Fix BasicRuntimeIT does not add /context-path when SERVER_HOST/server.host is overriden.
@rhusar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
…on non-OpenAPI compliant runtime
Fixes
https://issues.redhat.com/browse/WFLY-19229