Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-18745] introduced new single-step profile for integration tests… #791

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

istudens
Copy link
Contributor

@istudens istudens commented Dec 1, 2023

… with provisioned server

Issue: https://issues.redhat.com/browse/WFLY-18781

Copy link

openshift-ci bot commented Dec 1, 2023

Hi @istudens. Thanks for your PR.

I'm waiting for a wildfly member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jamezp
Copy link
Member

jamezp commented Dec 1, 2023

We absolutely need this.

@@ -235,6 +235,50 @@
</plugins>
</build>
</profile>
<profile>
<id>integration-testing-with-provisioned-server</id>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need the maven-failsafe-plugin defined and a way to define the server.host by default IMO. This won't work unless you explicitly set that property if used with the provisioned-server profile.

@emmartins
Copy link
Contributor

There are use cases where a single step profile won't work, e.g. quickstarts which needs to add users, so I believe that we need is to support both use cases, the current manual multi step way, and an optimized single step way. By support I mean that both the share-docs and CI should allow a QS to easily opt between those 2 ways, for instance by including asciidoc "A" or "B" and sending an input param in the QS CI yml. Honestly I would prefer this work to be done once we are done with all the current ongoing enhancements, so we have a full picture of what each "way" needs to support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants