[ELY-2721] upgraded to ApacheDS AM27 and Apache Kerby KDC #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@istudens FYI I just enabled CI for you |
fjuma
requested changes
Mar 14, 2024
| @@ -642,11 +642,6 @@ | |||
| <artifactId>apacheds-kerberos-codec</artifactId> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.apache.directory.server</groupId> | |||
| <artifactId>apacheds-protocol-kerberos</artifactId> | |||
There was a problem hiding this comment.
Can this be removed from the main pom.xml as well?
| try { | ||
| kdcServer.stop(); | ||
| } catch (KrbException e) { | ||
| // ignore |
There was a problem hiding this comment.
Might be good to throw an IllegalStateException here to be consistent with other exceptions that are caught in this test class.
|
@fjuma thanks for the review |
fjuma
approved these changes
Mar 15, 2024
darranl
approved these changes
Mar 15, 2024
|
Thank you for taking on this task and looking into the Kerby changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/ELY-2721