ELY-2379 Rename a local variable in FileAuditEndpoint class [local_variable_renamed] #2059
Conversation
OluchukwuCatherineObi-Njoku
requested review from
fjuma and
Skyllarr
as code owners
There was a problem hiding this comment.
Hi @OluchukwuCatherineObi-Njoku , thank you for the PR! I added some feedback
| @@ -70,22 +70,22 @@ public class FileAuditEndpoint implements AuditEndpoint { | |||
| } | |||
|
|
|||
| void setFile(final File file) throws IOException { | |||
| boolean ok = false; | |||
| boolean isSetUp = false; | |||
There was a problem hiding this comment.
@OluchukwuCatherineObi-Njoku Please rename to for example isFileSet or fileSet to be more specific about what has been set
There was a problem hiding this comment.
Hello. I made the suggested updates. Thanks
There was a problem hiding this comment.
Hello. I made the suggested updates. Thanks
| @@ -108,7 +108,7 @@ private void safeClose(Closeable c) { | |||
| * This method can be overridden by subclasses to modify data written into file (to encrypt them for example), | |||
| * or just for counting amount of written bytes for needs of log rotation and similar. | |||
| * | |||
| * This method can be invoked only in synchronization block surrounding one log message processing. | |||
| * This method can be invisSetUped only in synchronization block surrounding one log message processing. | |||
There was a problem hiding this comment.
@OluchukwuCatherineObi-Njoku This should not have been renamed, same goes for line 124
|
Hi @OluchukwuCatherineObi-Njoku |
There was a problem hiding this comment.
Thanks for the updates @OluchukwuCatherineObi-Njoku! Just one more spot where a word shouldn't be updated.
| @@ -121,7 +121,7 @@ void write(String toWrite) throws IOException { | |||
| * This method is NO-OP by default. It is intended to be overridden by subclasses | |||
| * which need to perform some operation before every writing into the target local file. | |||
| * | |||
| * This method can be invoked only in synchronization block surrounding one log message processing. | |||
| * This method can be invisFileSeted only in synchronization block surrounding one log message processing. | |||
|
Thank you for your PR FYI I have just submitted #2112 to correct the comment update that crept in with this PR. |
https://issues.redhat.com/browse/ELY-2379