Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ELY-2662] Upgrade jakarta.json:jakarta.json-api from 2.0.0 to 2.1.2 #2046

Closed
wants to merge 1 commit into from

Conversation

gabrielpadilh4
Copy link
Contributor

Copy link
Contributor

@Skyllarr Skyllarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gabrielpadilh4 !

@fjuma
Copy link
Contributor

fjuma commented Oct 31, 2023

@gabrielpadilh4 Thanks for the PR! Looks like there are related test failures in CI:

https://github.com/wildfly-security/wildfly-elytron/actions/runs/6633479695/job/18021291993?pr=2046

ELY-2662 Upgrade jakarta.json:jakarta.json-api from 2.0.0 to 2.1.2
@gabrielpadilh4
Copy link
Contributor Author

gabrielpadilh4 commented Oct 31, 2023

Hello @fjuma @Skyllarr it seems that jakarta.json 2.1 removed the default implementation from the specification api[1].

The implementation is eclipse parsson which changed some artifacts from org.glassfish to org.eclipse.parsson on version 1.0, see [2]

Based on that, i also changed the org.glassfish dependencies to org.eclipse.parsson and version 1.1.3 that it is the latest.

What do you think ?

[1] https://jakarta.ee/specifications/jsonp/2.1/
[2] https://projects.eclipse.org/projects/ee4j.parsson/releases/1.0.0/plan

@fjuma
Copy link
Contributor

fjuma commented Nov 8, 2023

Hello @fjuma @Skyllarr it seems that jakarta.json 2.1 removed the default implementation from the specification api[1].

The implementation is eclipse parsson which changed some artifacts from org.glassfish to org.eclipse.parsson on version 1.0, see [2]

Based on that, i also changed the org.glassfish dependencies to org.eclipse.parsson and version 1.1.3 that it is the latest.

What do you think ?

[1] https://jakarta.ee/specifications/jsonp/2.1/ [2] https://projects.eclipse.org/projects/ee4j.parsson/releases/1.0.0/plan

Thanks for the update, @gabrielpadilh4!

@PrarthonaPaul Would you be able to check if this aligns with what is currently used by WildFly?

@PrarthonaPaul
Copy link
Contributor

Hello @fjuma @Skyllarr it seems that jakarta.json 2.1 removed the default implementation from the specification api[1].
The implementation is eclipse parsson which changed some artifacts from org.glassfish to org.eclipse.parsson on version 1.0, see [2]
Based on that, i also changed the org.glassfish dependencies to org.eclipse.parsson and version 1.1.3 that it is the latest.
What do you think ?
[1] https://jakarta.ee/specifications/jsonp/2.1/ [2] https://projects.eclipse.org/projects/ee4j.parsson/releases/1.0.0/plan

Thanks for the update, @gabrielpadilh4!

@PrarthonaPaul Would you be able to check if this aligns with what is currently used by WildFly?

It looks like WildFly-core still uses Glassfish: https://github.com/wildfly/wildfly-core/blob/43143580a4b60fef3671c557588d587c492ade1b/pom.xml#L205
same with wildfly it seems:
https://github.com/wildfly/wildfly/blob/a3a43c0bae70d14fee13e34cbdb5898f5cd47139/boms/user/client/jms-client/pom.xml#L104-L107
But the wildfly parent pom doesn't have either

@gabrielpadilh4
Copy link
Contributor Author

@PrarthonaPaul also it's good to mention that wildfly-core uses version 1.1.6 of jakarta json glassfish while elytron uses 2.0.0

<version.org.glassfish.jakarta.json>1.1.6</version.org.glassfish.jakarta.json>

<version.org.glassfish.jakarta.json>2.0.0</version.org.glassfish.jakarta.json>

@darranl
Copy link
Contributor

darranl commented Mar 14, 2024

Thank you for the PR, FYI I have just resubmitted here to resolve the merge conflict #2111

@darranl darranl closed this Mar 14, 2024
@gabrielpadilh4 gabrielpadilh4 deleted the ELY-2662 branch March 14, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants