[ELY-2591] Move min method into the PeriodicRotatingFileAuditEndpoint… #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skyllarr
approved these changes
Sep 27, 2023
Skyllarr
reviewed
Sep 29, 2023
| @@ -174,6 +174,10 @@ public static class Builder extends FileAuditEndpoint.Builder { | |||
| super(); | |||
| } | |||
|
|
|||
| private static <T extends Comparable<? super T>> T min(T a, T b) { | |||
There was a problem hiding this comment.
@gerjantd Just a total minor, can you please place this method below the public methods in the Builder class for convention reasons? Thank you!
There was a problem hiding this comment.
@Skyllarr done. I squashed the commits. Do you need a new PR or can you take it from here?
darranl
approved these changes
Mar 8, 2024
|
Thank you @gerjantd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…#Builder class
https://issues.redhat.com/browse/ELY-2591