ELY-2638 : Simplify test assertions in SSLAuthenticationTest #1960
Conversation
| import static org.junit.Assert.fail; | ||
| import static org.junit.Assert.assertNotNull; | ||
| import static org.junit.Assert.assertNull; | ||
| import static org.junit.Assert.*; |
There was a problem hiding this comment.
Hello @nidhiazad , this PR looks great!
Just a total minor. I can still see this asterisk here, this will make the build fail as we are using a checkstyle plugin to avoid the asterisk imports. Please use the individual classes names when importing and update this PR
Let us know if you need any help with that ! Thank you!
There was a problem hiding this comment.
I have made the changes. Kindly review and let me know if anything needs to be done.
There was a problem hiding this comment.
Hi @nidhiazad, thanks for the updates! In general, we try to squash all the commits for a given issue into a single one. Could you do that for this PR?
Let me know if you need any assistance in doing so!
|
@nidhiazad Just a minor, please squash the 2 commits into a single commit. Thank you! |
Hi @Skyllarr |
|
Closing this PR. Thank you @PrarthonaPaul and @nidhiazad ! |
https://issues.redhat.com/browse/ELY-2638