Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ELY 2173] Add test for the CLIENT_CERT mechanism #1955

Merged
merged 1 commit into from Mar 28, 2024
Merged

[ELY 2173] Add test for the CLIENT_CERT mechanism #1955

merged 1 commit into from Mar 28, 2024

Conversation

Dkafetzis
Copy link

darranl
darranl requested changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@darranl darranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, I would just mention a couple of the new files are missing the standard copyright header we use in the project if you are able to please add them.

@Dkafetzis
Copy link
Author

@darranl Thanks for the correction. I've also rebased the branch to the latest 2.x changes.

darranl
darranl approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@darranl darranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Dkafetzis looks like the CI run was green as well.

@darranl darranl added the +1 DAL label Mar 15, 2024
fjuma
fjuma requested changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Dkafetzis! Have added some small comments.

tests/base/src/test/java/org/wildfly/security/http/impl/AbstractBaseHttpTest.java Outdated Show resolved Hide resolved
@Dkafetzis Dkafetzis requested a review from fjuma March 21, 2024 09:31
@Dkafetzis
Copy link
Author

@fjuma Could I get a review on this again?

@Dkafetzis Dkafetzis requested a review from fjuma March 27, 2024 08:24
fjuma
fjuma approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@fjuma fjuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Dkafetzis!

@fjuma fjuma added the +1 FJ label Mar 28, 2024
@fjuma fjuma merged commit 76b40c1 into wildfly-security:2.x Mar 28, 2024
3 checks passed
@Dkafetzis Dkafetzis deleted the ELY-2173 branch March 29, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darranl darranl darranl approved these changes

@fjuma fjuma fjuma approved these changes

@Skyllarr Skyllarr Awaiting requested review from Skyllarr Skyllarr is a code owner

Assignees
No one assigned
Labels
+1 DAL +1 FJ
Projects
None yet
Milestone
No milestone
3 participants
@Dkafetzis @darranl @fjuma