Hygiene: clean up code in PageAvailableOfflineHandler #4651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrant
requested changes
May 21, 2024
app/src/main/java/org/wikipedia/page/PageAvailableOfflineHandler.kt
Outdated
Show resolved
Hide resolved
dbrant
requested changes
May 22, 2024
| }) { | ||
| val readingListPage = withContext(Dispatchers.IO) { AppDatabase.instance.readingListPageDao().findPageInAnyList(pageTitle) } | ||
| val readingListPage = AppDatabase.instance.readingListPageDao().findPageInAnyList(pageTitle) |
There was a problem hiding this comment.
I believe this might still need to be wrapped in withContext(Dispatchers.IO). The function findPageInAnyList() doesn't suspend, so it will run on the default dispatcher of the scope (Main).
The way this is currently written, it doesn't need to be a coroutine (there's nothing that suspends).
dbrant
requested changes
May 22, 2024
| @@ -130,7 +136,7 @@ interface ReadingListPageDao { | |||
| updateThumbAndDescriptionByName(pageProto.lang, pageProto.apiTitle, thumbUrl, description) | |||
| } | |||
|
|
|||
| fun findPageInAnyList(title: PageTitle): ReadingListPage? { | |||
| suspend fun findPageInAnyList(title: PageTitle): ReadingListPage? { | |||
| return getPageByParams( | |||
There was a problem hiding this comment.
The getPageByParams function also needs to be suspend, since that's where Room actually does its job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process only needs the
Dispatchers.IOand there's no need to applywithContext()and an additionalrun{}inCoroutineExceptionHandlerblock.