Use Coroutine in PageFragmentLoadState #4649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrant
requested changes
May 21, 2024
| .doAfterTerminate { pageLoadFromNetwork { fragment.onPageLoadError(it) } } | ||
| .subscribe()) | ||
| clientJob?.cancel() | ||
| clientJob = CoroutineScope(Dispatchers.Main).launch { |
There was a problem hiding this comment.
The CoroutineScope can be passed into this class from the parent PageFragment's lifecycleScope.
There was a problem hiding this comment.
Done!
I also removed the try-catch and used CoroutineExceptionHandler. It now shows a different error message "There was a network error.` vs. the original one "Cannot connect to internet" with a more detailed error message. Which one do we want to use?
There was a problem hiding this comment.
Note: after switching to use the lifecycleScope from parentFragment, the try-catch will cause a crash 🤔
|
Merging, since I will have a follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a related PR for the upcoming
PageFragmentandPageActivityViewModel work,